Many handlers perf2 #3313
Closed
Many handlers perf2 #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are only going to return "first 50" from the API for our UI, we can keep the pipe lazy so that only 50 rows ever get processed. This makes the handled applications opening a bit faster. The `get-handled-applications` is also extracted for convenience of calling in e.g. a performance test.
This makes it easier to see over time if we are slower or faster. We would like this to be as fast as possible.
Let's use a single SQL statement to send many emails instead of many calls. NB, we must change the mocking to fake the new method.
We can cache the user attributes like we do user settings. Ideas for later: - We cache user settings separately from user cache, when we should likely only have one cache for all user attributes, settings and roles. - Changing user settings should invalidate user cache because it contains settings too (`:notification-email`) - We should really now remove format/unformat user. - All other parts of REMS outside of tests should rather use complete user and any "raw attributes" should be internal to user ns or gone completely. - We should consider what removing a user means. The function that exists should not be needed as it is.
- using `reduce` is much faster than `mapcat` - `if-some` is cleaner here
Schema checking of large results is very slow. We should consider leaving it out of some APIs where performance matters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for author
Remove items that aren't applicable, check items that are done.
Reviewability
Backwards compatibility
Documentation
Testing
Follow-up