-
Notifications
You must be signed in to change notification settings - Fork 5
Migrate from vue-cli to vite #982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3a6fcb0
to
b4d1d11
Compare
should we wait for #929 before, or when we have all the features before the release, before we proceed with this ? |
I think so |
Looks good and it works as expected for me 👍 |
b4d1d11
to
a3cce2b
Compare
Rebased, and added github PR number to the changelog. |
I'll mark it as WIP while we wait for other PR to be merged |
a3cce2b
to
5a0e046
Compare
I've been developing off this branch, and the dev server doesn't work well with the current configuration. |
5f2ec2d
to
b592d2c
Compare
rebased |
b592d2c
to
aa80c68
Compare
rebased and added https mode for dev server |
aa80c68
to
e1550ef
Compare
The devserver seems to behave well now. I still need to test that websockets work, though. |
e1550ef
to
6aa7654
Compare
websockets work |
8f6b8cf
to
c0202c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i personally do not spot anything at this time, was able to build and run it, however best to wait for other reviewers before merging
Worked well for me in most of the pages, some exceptions are for pages such as |
c0202c0
to
8566a0a
Compare
@hannyle, it should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely, Vite seems considerably quicker in the hot-reloads of files. Took a bit of getting used to the files not getting built initially, though.
Approved, everything seems to work 👌🏼
461c039
4d45907
to
461c039
Compare
Description
vue-cli
is not the recommended tool forvue
projects any more, and migrating tovite
is a step towards migrating tovue3
.Quite many changes were needed, but it looks like it works as before. Development workflows shouldn't be affected, as the
pnpm
commands are the same.The most significant change for the project structure is that for a multipage app (with multiple HTML entries), the HTML files need to be declared specifically for each entry.
The biggest difference, as I understood, between both tools is the underlying bundler, and the dev server.
The bundler in
vue-cli
iswebpack
, while forvite
it'srollup
.They claim that
vite
's dev server is superfast, but what it actually does is build dependencies on demand, so it looks faster to start, but while browsing some waiting usually follows. It might anyway be an improvement overvue-cli
.The browser compatibility is also supposed to be good enough, even without babel or autoprefixer:
Related issues
Type of change
Changes Made
vue-cli
and dependenciesvite
and its dependenciesvue-cli
config tovite
config.vue
to the imports, which also makes type hinting workcss
import statementscss
styles instyle
blocks was changed to global "import" configured invite.config.js
/browse
page as an SPA, and the otherhtml
files as wellTesting
Please, check that the setup works as expected!
Mentions