Skip to content

Conversation

CSenshi
Copy link
Owner

@CSenshi CSenshi commented Aug 17, 2025

Description

This is workaround, this should be DI but for some reason. HealthIndicatorService is not injected after building the package.
Solution: Just create new one in constructor instead of relying on nest DI

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Testing

  • Tests added/updated

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Tests pass locally
  • Documentation updated (if needed)
  • Conventional commit format used

Related Issues

Closes #6

Copy link

nx-cloud bot commented Aug 17, 2025

View your CI Pipeline Execution ↗ for commit 1f324b0

Command Status Duration Result
nx affected -t lint test build ✅ Succeeded 29s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-17 19:37:35 UTC

Copy link

codecov bot commented Aug 17, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...kages/health-indicator/src/lib/health.indicator.ts 88.88% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CSenshi CSenshi force-pushed the fix/health-indicator-resolver branch from 367d722 to 1f324b0 Compare August 17, 2025 19:35
@CSenshi CSenshi merged commit 6d5df6a into main Aug 17, 2025
3 checks passed
@CSenshi CSenshi deleted the fix/health-indicator-resolver branch August 17, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Unexpected behavior when using RedisHealthIndicator
1 participant