Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#10) allow passing query as parameter #14

Merged
merged 7 commits into from
Apr 20, 2023
Merged

(#10) allow passing query as parameter #14

merged 7 commits into from
Apr 20, 2023

Conversation

frankli0324
Copy link
Contributor

@frankli0324 frankli0324 commented Mar 30, 2023 •
edited by ColdHeat
Loading

  • Add the ability to pass query parameters to the getChallenges function
  • Add getUsers and getTeams

ColdHeat
ColdHeat reviewed Apr 20, 2023
View reviewed changes
fetch.js Outdated
if (options === undefined) {
options = {
method: "GET",
credentials: "same-origin",
headers: {},
};
}
url = config.urlRoot + url;

url = new URL(ltrim(url), rfill(config.urlRoot));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is supposed to be something more like:

new URL(config.urlRoot + url, window.location.origin)

@ColdHeat ColdHeat merged commit aee47ca into CTFd:main Apr 20, 2023
@ColdHeat ColdHeat mentioned this pull request Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColdHeat ColdHeat ColdHeat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankli0324 @ColdHeat