-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/smoothscale #14
Conversation
…E backend gives slightly different results
|
||
bpp = c_surf.format.BytesPerPixel | ||
if bpp < 3 or bpp > 4: | ||
raise ValueError("Only 24-bit or 32-bit surfaces can be" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking whether we should we be throwing an SDLError
here?
And a similar question for other places where we raise ValueError.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pygame throws ValueError in it's version, so we're just matching behaviour here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, otherwise looks good. |
Comments addressed. Ready for another review. |
@drnlm Can you merge in develop? |
👍 |
Implement GENERIC smoothscale backend
This implements transform.smoothscale, using the C-only generic implementation.
This doesn't attempt to duplicate the optimised MMX and SSE implementations pygame provides as they give slightly different visual results and the complexity doesn't seem worth it for something so x86 specific.
This should be enough to close issue #7