Feature/smoothscale #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 13, 2015 16:16
…E backend gives slightly different results
|
|
||
| bpp = c_surf.format.BytesPerPixel | ||
| if bpp < 3 or bpp > 4: | ||
| raise ValueError("Only 24-bit or 32-bit surfaces can be" |
There was a problem hiding this comment.
Just checking whether we should we be throwing an SDLError here?
And a similar question for other places where we raise ValueError.
There was a problem hiding this comment.
pygame throws ValueError in it's version, so we're just matching behaviour here
|
Left a few comments, otherwise looks good. |
|
Comments addressed. Ready for another review. |
|
@drnlm Can you merge in develop? |
|
👍 |
drnlm
added a commit
that referenced
this pull request
Jun 15, 2015
Implement GENERIC smoothscale backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements transform.smoothscale, using the C-only generic implementation.
This doesn't attempt to duplicate the optimised MMX and SSE implementations pygame provides as they give slightly different visual results and the complexity doesn't seem worth it for something so x86 specific.
This should be enough to close issue #7