Catch up py3k support #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You didn't mean to use the buffer builtin there. Going from the C implementation, the expected thing to do here is limit the chunk size.
With an integer argument
| def chr_(o): | ||
| if sys.version_info >= (3, 0, 0): | ||
| return bytes((o,)) | ||
| return chr(o) |
There was a problem hiding this comment.
Should this not rather be:
if sys.version_info >= (3, 0, 0):
def chr_(o):
return bytes((o,))
else:
chr_ = chr
|
Left one niggly stylistic comment, otherwise 👍. |
| @@ -49,13 +51,14 @@ def save(surface, filename): | |||
| fn_normalized = filename.lower() | |||
| result = 0 | |||
| # TODO: prep/unprep surface | |||
| if fn_normalized.endswith('bmp'): | |||
| if fn_normalized.endswith(as_bytes('bmp')): | |||
There was a problem hiding this comment.
Do we really need as_bytes here?
Don't we only support recent enough python 2 versions that we can just use b'bmp'?
There was a problem hiding this comment.
That was my first approach. But then I saw that we had as_bytes for this. I'm happy to remove as_bytes entirely.
We don't support Python 2.6 or 3.2, any more.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 support has been neglected for a while. This gets all the upstream unit tests that pass on Python 2, to pass on Python 3.