fix draw.lines() with all lines clipped #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the set of lines given to draw.lines() are all outside the surface, it will pass _make_drawn_rect() an empty array and trigger an exception. This patch makes it return None instead in this case. See _clip_and_draw_line_width() for similar code.
fijal
added a commit
that referenced
this pull request
Mar 13, 2015
fix draw.lines() with all lines clipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the set of lines given to draw.lines() are all outside the surface,
it will pass _make_drawn_rect() an empty array and trigger an
exception.
This patch makes it return None instead in this case. See
_clip_and_draw_line_width() for similar code.