-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/enable appveyor #75
Conversation
solution making them discoverable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left some minor comments.
- "python -m test" | ||
|
||
#artifacts: | ||
# - path: dist\* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be uncommented? Or removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My plan is to have appveyor build wheels for us. It already runs bdist_wheel, but I still need to work out how to include the required dlls. Once that's in place, I'll uncomment this so we can grab the produced wheels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool.
appveyor/README.rst
Outdated
@@ -0,0 +1,3 @@ | |||
Appveyor is a service we use to build windows binaries for pygame_cffi. | |||
|
|||
We borrow varioys helpers, like the install.psi script, from the pygame project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/psi/ps1/?
appveyor/copydlls.ps1
Outdated
$destpath = $basedir + "pygame" | ||
|
||
Write-Host "dlls from" $dlls | ||
Write-Host "destiation" $destpath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/destiation/destination/
return $filepath | ||
} | ||
|
||
# Download and retry up to 5 times in case of network transient errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/5/3/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We copy the install.ps1 script verbatim from pygame, comment errors and all.
I'd prefer to keep the two in sync, so it's trivial to spot when pygame updates something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool.
else: | ||
return ['prebuilt-x64/include', 'prebuilt-x64/include/SDL'] | ||
return ['/usr/include', '/usr/include/SDL', '/usr/local/include/SDL'] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might be missing a newline between these two functions. Should we perhaps add docstrings to these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one small typo, otherwise looks good.
README.md
Outdated
|
||
## Building on windows | ||
|
||
To build on windows, you need to download the appropriate dependancy libraries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/dependancy/dependency/
- "python -m test" | ||
|
||
#artifacts: | ||
# - path: dist\* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool.
This adds appveyor support for testing pygame_cffi on windows.
A number of tests faill, at least partly because RWops isn't correct on windows platforms, but at least the tests run.