Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs/windows needs explicit binary open #90

Merged
merged 2 commits into from
Apr 9, 2017

Conversation

drnlm
Copy link
Member

@drnlm drnlm commented Apr 8, 2017

Windows defaults to using 'cp1252' if the file is opened in text mode, which fails for arbitary binary data. We should be explicit about opening binary objects as binary.

@drnlm drnlm merged commit 666c288 into master Apr 9, 2017
@drnlm drnlm deleted the bugs/windows_needs_explicit_binary_open branch April 9, 2017 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants