Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate_email dependency #36

Closed
tumbl3w33d opened this issue Jul 19, 2024 · 4 comments
Closed

validate_email dependency #36

tumbl3w33d opened this issue Jul 19, 2024 · 4 comments

Comments

@tumbl3w33d
Copy link

I've been using envelope for a few years and last night my CI build broke due to the dependency validate_email gone missing:

  File "/home/jenkins/agent/workspace/myproject/app.py", line 4, in <module>
    from envelope import Envelope
  File "/usr/local/lib/python/envelope/__init__.py", line 1, in <module>
    from .envelope import Envelope
  File "/usr/local/lib/python/envelope/envelope.py", line 29, in <module>
    from .address import Address
  File "/usr/local/lib/python/envelope/address.py", line 8, in <module>
    from validate_email import validate_email  # noqa, #17 E402, the package name is py3-validate-email
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'validate_email'

I went to pypi to figure out the status of that module and noticed there are a few candidates with very different age. Could you elaborate what changed recently that possibly caused this and which module I should install, if I am to fix this on my own?

@e3rd
Copy link
Member

e3rd commented Jul 19, 2024

Strange it happened! The module the envelope uses is https://pypi.org/project/py3-validate-email/ . As I read there, the author decided to leave pypi but the last version seems up and working.

The package name is correctly stated in https://github.com/CZ-NIC/envelope/blob/master/requirements.txt which means py3-validate-email should have been correctly installed alongside envelope.

@tumbl3w33d
Copy link
Author

Alright, thanks for confirming the package name. When I explicitly add that to my requirements.txt in addition to envelope, it works as expected. Might be a bug or change of behavior in the alpine toolchain (which is not exactly python-friendly). I'm building all of this in a multistage dockerfile and there were no errors whatsoever, but it just wouldn't install this dependency.

Adding that explicit dependency is a workaround that I can live with. Thank you for your feedback!

@e3rd
Copy link
Member

e3rd commented Jul 19, 2024

Thanks for having investigated! If that will raise the issue for other people, I'll try to tackle it more.

@e3rd e3rd closed this as completed Jul 19, 2024
e3rd added a commit that referenced this issue Jul 22, 2024
e3rd added a commit that referenced this issue Jul 22, 2024
@e3rd
Copy link
Member

e3rd commented Jul 22, 2024

It was some strange things...

I had different dependency package versions specified for different Python3.8; some newer releases were declined by Pypi due to licensing (it seems) and hence, when build from Pypi, dependency missed. No, it should work again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants