-
Notifications
You must be signed in to change notification settings - Fork 52
Add support for python 3.11 #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hosaka Try using macos-13 to get a x86_64 runner, it works. |
@hosaka Also, Python 3.12--3.13 is stable, so might add those as well. EDIT Problem here: exclude these versions from PySide2, but only for Windows [edited again]. |
@hosaka Seems like some caching is occuring... pyqt5 and pyqt6 seemed preinstalled on the runner with wrong architechture. Try adding a step with
To remove the existing venv to see if things improve. |
@hosaka Sorry, it's occuring at the install Qt not the deps step... I apologize for this wrong suggestion. I will addd another comment. |
Exclude python versions incompatible with qt backend libs Always get a qt backend in local venv, ignoring runner site-packages
@hosaka CI passed! Could you please explain the test modification? |
A line was added to the The author talks about a use case where an async reader is removed from a file descriptor during the callback, and a async writer is added instead, or vice-versa (which appears to be a valid scenario). The test that resulted from that discussion replicates this condition but breaks in python 3.11 due to
Since Test run in python 3.10 (cb callbacks act as one-shot events)
Same run in python 3.11 (followed by
|
No description provided.