Skip to content

Optional argument to QEventLoop constructor for already running loops #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Optional argument to QEventLoop constructor for already running loops #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion qasync/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ class _QEventLoop:
... loop.run_until_complete(xplusy(2, 2))
"""

def __init__(self, app=None, set_running_loop=True):
def __init__(self, app=None, set_running_loop=True, already_running=False):
self.__app = app or QApplication.instance()
assert self.__app is not None, 'No QApplication has been instantiated'
self.__is_running = False
Expand All @@ -278,6 +278,11 @@ def __init__(self, app=None, set_running_loop=True):
if set_running_loop:
asyncio.events._set_running_loop(self)

# We have to set __is_running to True after calling
# super().__init__() because of a bug in BaseEventLoop.
if already_running:
self.__is_running = True

def run_forever(self):
"""Run eventloop forever."""
self.__is_running = True
Expand Down