Skip to content

Fix #4 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2020
Merged

Fix #4 #5

merged 1 commit into from
Feb 26, 2020

Conversation

selplacei
Copy link
Contributor

P.S. Subclassing QObjects with asyncSlots is impossible without this.

@selplacei selplacei changed the title Fix https://github.com/CabbageDevelopment/qasync/issues/4 Fix #4 Feb 25, 2020
@TheGreatCabbage
Copy link
Member

TheGreatCabbage commented Feb 25, 2020 •
edited
Loading

Thanks for your contribution! I'll test this out later tomorrow.

@TheGreatCabbage TheGreatCabbage linked an issue Feb 26, 2020 that may be closed by this pull request
Wrapper for asyncSlot decorator returns None. #4
Closed
@TheGreatCabbage TheGreatCabbage merged commit 36420a6 into CabbageDevelopment:master Feb 26, 2020
@TheGreatCabbage
Copy link
Member

Thanks, this is now live in qasync==0.9.4!

TheGreatCabbage pushed a commit to TheGreatCabbage/asyncqt that referenced this pull request Feb 29, 2020
@selplacei @TheGreatCabbage
Merge CabbageDevelopment/qasync#5 into TheGreatCabbage/asyncqt
be95144
@TheGreatCabbage TheGreatCabbage mentioned this pull request Feb 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheGreatCabbage TheGreatCabbage Awaiting requested review from TheGreatCabbage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrapper for asyncSlot decorator returns None.
2 participants
@selplacei @TheGreatCabbage