Fixing #5514 - DSStats Errors

DS Stats issues warnings when the RRDfile has not been initialized
Cacti · Sep 30, 2023 · 6e35813 · 6e35813
1 parent 3682057
commit 6e35813
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -13,6 +13,7 @@ Cacti CHANGELOG
 -issue#5496: Plugin Management CLI does not work when multiple plugins are specified
 -issue#5502: Errors related to php 8.3 and page generation including a checkbox
 -issue#5503: Note, we could not process all your actions. Details are below
+-issue#5514: DS Stats issues warnings when the RRDfile has not been initialized 
 
 1.2.25
 -security#GHSA-77rf-774j-6h3p: Protect against Insecure deserialization of filter data

diff --git a/lib/dsstats.php b/lib/dsstats.php
@@ -435,8 +435,10 @@ function dsstats_obtain_data_source_avgpeak_values($rrdfile, $interval, &$pipes)
 
 								break;
 							} else {
-								foreach($position[$index] as $dsname => $stat) {
-									$dsvalues[$dsname][$stat] = trim($line);
+								if (isset($position[$index]) && cacti_sizeof($position[$index])) {
+									foreach($position[$index] as $dsname => $stat) {
+										$dsvalues[$dsname][$stat] = trim($line);
+									}
 								}
 							}
 						}