-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] (2.0.0) Optimize ProfileSelectWindow #305
Conversation
FrostyEditor/ViewModels/Windows/ProfileSelectWindowViewModel.cs
Outdated
Show resolved
Hide resolved
FrostyEditor/ViewModels/Windows/ProfileSelectWindowViewModel.cs
Outdated
Show resolved
Hide resolved
FrostyEditor/ViewModels/Windows/ProfileSelectWindowViewModel.cs
Outdated
Show resolved
Hide resolved
FrostyEditor/ViewModels/Windows/ProfileSelectWindowViewModel.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: jona <93538252+wannkunstbeikor@users.noreply.github.com>
…106/SuperCheatedFrostyToolsuite into 2.0.0_ProfileSelectFix
…106/SuperCheatedFrostyToolsuite into 2.0.0_ProfileSelectFix
Should I put frosty icon in Theme? |
do u mean the svg, if so yeah u can |
<Grid Grid.Row="0"> | ||
<ListBox ItemsSource="{Binding Profiles}" SelectedItem="{Binding SelectedProfile}"> | ||
|
||
<ExperimentalAcrylicBorder IsHitTestVisible="False"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all join the frosty discord and head to the #developers channel, since its probably better to discuss what kind of theme frosty should use. Second things like this should go into its own control, sth like FrostyWindow which has the icon at the top and a name prop, etc so it doesnt need to duplicated for every window
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry I did that, but the discord link in readme can't be opened.
Try to share the server instead of copying from browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated it
@@ -12,6 +12,7 @@ public ProfileSelectWindow() | |||
#if DEBUG | |||
this.AttachDevTools(); | |||
#endif | |||
PointerPressed += (_, e) => BeginMoveDrag(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think dragging is necessary, but like i said discuss it in the discord
I'm sorry I did that, but the discord link in readme can't be opened. |
…106/SuperCheatedFrostyToolsuite into 2.0.0_ProfileSelectFix
u need to react to the message in the readme |
oh sorry, I’m there now |
then send the picture u send here in there and ask what others think about it |
@@ -0,0 +1,15 @@ | |||
<UserControl xmlns="https://github.com/avaloniaui" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not work on linux, so i think just setting the title of the window is enough for now
@shoushou1106 can u make a pr for this on my fork |
Add verify for AddProfile
Add DeleteProfile
Change Window size and Title
Need MessageBox, but I don't know which to choose or what to do
Maybe AvaloniaCommunity/MessageBox.Avalonia
or maybe make a new one