Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] (2.0.0) Optimize ProfileSelectWindow #305

Closed
wants to merge 41 commits into from

Conversation

shoushou1106
Copy link
Contributor

@shoushou1106 shoushou1106 commented Aug 28, 2023

Add verify for AddProfile
Add DeleteProfile
Change Window size and Title

Need MessageBox, but I don't know which to choose or what to do
Maybe AvaloniaCommunity/MessageBox.Avalonia
or maybe make a new one

@shoushou1106
Copy link
Contributor Author

Should I put frosty icon in Theme?

@wannkunstbeikor
Copy link
Collaborator

Should I put frosty icon in Theme?

do u mean the svg, if so yeah u can

@shoushou1106
Copy link
Contributor Author

shoushou1106 commented Aug 29, 2023

图片
I'm trying adding game icon now

FrostyEditor/Languages/en-US.axaml Outdated Show resolved Hide resolved
<Grid Grid.Row="0">
<ListBox ItemsSource="{Binding Profiles}" SelectedItem="{Binding SelectedProfile}">

<ExperimentalAcrylicBorder IsHitTestVisible="False">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all join the frosty discord and head to the #developers channel, since its probably better to discuss what kind of theme frosty should use. Second things like this should go into its own control, sth like FrostyWindow which has the icon at the top and a name prop, etc so it doesnt need to duplicated for every window

Copy link
Contributor Author

@shoushou1106 shoushou1106 Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry I did that, but the discord link in readme can't be opened.
Try to share the server instead of copying from browser.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated it

@@ -12,6 +12,7 @@ public ProfileSelectWindow()
#if DEBUG
this.AttachDevTools();
#endif
PointerPressed += (_, e) => BeginMoveDrag(e);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think dragging is necessary, but like i said discuss it in the discord

@shoushou1106
Copy link
Contributor Author

I'm sorry I did that, but the discord link in readme can't be opened.
Try to share the server instead of copying from browser.

@wannkunstbeikor wannkunstbeikor dismissed their stale review August 29, 2023 14:05

needs more work

@wannkunstbeikor wannkunstbeikor marked this pull request as draft August 29, 2023 14:06
@shoushou1106
Copy link
Contributor Author

updated it

Omg I'm already in that channel but I don't see #developers, maybe i dont have permission

Screenshot in #read-me
maybe this channel? translate: "🔒No access permissions"

@wannkunstbeikor
Copy link
Collaborator

u need to react to the message in the readme

@shoushou1106
Copy link
Contributor Author

oh sorry, I’m there now

@wannkunstbeikor
Copy link
Collaborator

then send the picture u send here in there and ask what others think about it

@@ -0,0 +1,15 @@
<UserControl xmlns="https://github.com/avaloniaui"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not work on linux, so i think just setting the title of the window is enough for now

@wannkunstbeikor
Copy link
Collaborator

@shoushou1106 can u make a pr for this on my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants