-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] metadata issue, fixes #74 #83
Conversation
export { IntercomShowMessagesDirective } from './src/app/ng-intercom/directives/show-messages.directive' | ||
export { IntercomShowNewMessageDirective } from './src/app/ng-intercom/directives/show-new-message.directive' | ||
export { IntercomShutdownDirective } from './src/app/ng-intercom/directives/shutdown.directive' | ||
export { IntercomTrackEventDirective } from './src/app/ng-intercom/directives/track-event.directive' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be enough, but I don't want to take a risk, so let me know if you want me to update it :
export { Intercom } from './src/app/ng-intercom/intercom/intercom'
export { IntercomConfig } from './src/app/ng-intercom/shared/intercom-config'
// export { IntercomHideDirective } from './src/app/ng-intercom/directives/hide.directive'
export { IntercomModule } from './src/app/ng-intercom/intercom.module'
// export { IntercomShowDirective } from './src/app/ng-intercom/directives/show.directive'
// export { IntercomShowMessagesDirective } from './src/app/ng-intercom/directives/show-messages.directive'
// export { IntercomShowNewMessageDirective } from './src/app/ng-intercom/directives/show-new-message.directive'
// export { IntercomShutdownDirective } from './src/app/ng-intercom/directives/shutdown.directive'
// export { IntercomTrackEventDirective } from './src/app/ng-intercom/directives/track-event.directive'
npm run test
and ng serve
both work with only those 3 exports (as does our app)
Thank you for the PR! I'm going to close and reopen this to trigger the CI. |
This will be released in #84 release 7.0.0-beta.1 |
thanks so much for your work, Luca ! |
Summary of changes:
Honestly, I'm not sure what was the issue, but I found that fix in
ngx-progressbar
which had the same issue some time ago :Other unrelated changes (I'll rollback if you want)
Also, I couldn't make
npm i
to work without it, becausenpm ERR! 404 Not Found: flatmap-stream@0.1.1
Intended/example use case:
Of course, first I made sure I was reproducing the issue, without this change, I get
With this fix, everything goes well now (Angular7, both
ng build --prod
andng xi18n
)Checklist:
npm run build
runs without errorng serve
spawns app, Intercom messenger is visible and interactive, and there are no errors in the consoleCloses issue: #74