[ImgBot] Optimize images #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![imgbot[bot]](https://avatars.githubusercontent.com/in/4706?s=60&v=4){kind=small}
*Total -- 189.17kb -> 174.02kb (8.01%) /editor/icons/TrackColor.svg -- 1.69kb -> 0.37kb (78.07%) /platform/android/java/lib/res/mipmap-xxxhdpi/icon_background.png -- 1.33kb -> 0.30kb (77.13%) /platform/android/java/lib/res/mipmap-xxhdpi/icon_background.png -- 0.88kb -> 0.29kb (66.74%) /platform/android/java/lib/res/mipmap-xhdpi/icon_background.png -- 0.50kb -> 0.29kb (43.13%) /editor/icons/ORMMaterial3D.svg -- 4.06kb -> 2.57kb (36.63%) /misc/dist/project_icon.svg -- 6.73kb -> 4.41kb (34.46%) /icon.svg -- 7.46kb -> 5.12kb (31.31%) /platform/android/java/lib/res/mipmap-hdpi/icon_background.png -- 0.37kb -> 0.28kb (22.4%) /logo.svg -- 21.80kb -> 17.46kb (19.92%) /editor/icons/CylinderShape3D.svg -- 0.33kb -> 0.30kb (10.88%) /editor/icons/GuiVsplitBg.svg -- 0.14kb -> 0.13kb (7.86%) /editor/icons/UnpaintVertex.svg -- 0.15kb -> 0.14kb (7.74%) /editor/icons/GuiScrollBg.svg -- 0.09kb -> 0.08kb (7.69%) /editor/icons/GuiProgressFill.svg -- 0.18kb -> 0.17kb (7.57%) /editor/icons/PaintVertex.svg -- 0.16kb -> 0.15kb (7.19%) /modules/gridmap/icons/GridMap.svg -- 0.29kb -> 0.27kb (6.33%) /editor/icons/GuiVTick.svg -- 0.15kb -> 0.14kb (6.33%) /editor/icons/ColorTrackVu.svg -- 0.88kb -> 0.83kb (5.86%) /editor/icons/KeySelected.svg -- 0.45kb -> 0.43kb (5.81%) /editor/icons/GuiHTick.svg -- 0.15kb -> 0.14kb (5.73%) /editor/icons/GuiScrollGrabber.svg -- 0.16kb -> 0.15kb (5.66%) /editor/icons/Callable.svg -- 0.33kb -> 0.31kb (5.65%) /editor/icons/GuiRadioUnchecked.svg -- 0.23kb -> 0.21kb (5.58%) /editor/icons/GuiScrollGrabberPressed.svg -- 0.16kb -> 0.15kb (5.56%) /editor/icons/GuiSpace.svg -- 0.20kb -> 0.19kb (5.37%) /editor/icons/TransitionSyncBig.svg -- 0.51kb -> 0.49kb (4.78%) /editor/icons/TransitionEndBig.svg -- 0.51kb -> 0.49kb (4.77%) /editor/icons/GuiRadioChecked.svg -- 0.33kb -> 0.32kb (4.72%) /editor/icons/CubeMesh.svg -- 0.33kb -> 0.31kb (4.5%) /editor/icons/GuiToggleOff.svg -- 0.26kb -> 0.25kb (4.49%) /editor/icons/GuiScrollGrabberHl.svg -- 0.16kb -> 0.15kb (4.4%) /editor/icons/ToolConnect.svg -- 0.29kb -> 0.27kb (4.11%) /editor/icons/ToolAddNode.svg -- 0.72kb -> 0.69kb (3.82%) /editor/icons/TransitionSyncAutoBig.svg -- 0.49kb -> 0.47kb (3.8%) /editor/icons/KeyValue.svg -- 0.26kb -> 0.25kb (3.79%) /editor/icons/TransitionEndAutoBig.svg -- 0.49kb -> 0.47kb (3.78%) /editor/icons/PointMesh.svg -- 0.26kb -> 0.25kb (3.77%) /editor/icons/InformationSign.svg -- 0.42kb -> 0.40kb (3.72%) /editor/icons/TransitionEnd.svg -- 0.42kb -> 0.40kb (3.28%) /editor/icons/TransitionEndAuto.svg -- 0.42kb -> 0.40kb (3.28%) /editor/icons/TransitionSyncAuto.svg -- 0.42kb -> 0.41kb (3.23%) /editor/icons/TransitionSync.svg -- 0.42kb -> 0.41kb (3.23%) /editor/icons/GuiUnchecked.svg -- 0.39kb -> 0.38kb (3.23%) /editor/icons/BezierHandlesMirror.svg -- 1.50kb -> 1.45kb (3.2%) /editor/icons/KeyAnimation.svg -- 0.25kb -> 0.24kb (3.15%) /editor/icons/KeyBezier.svg -- 0.25kb -> 0.24kb (3.15%) /editor/icons/KeyCall.svg -- 0.25kb -> 0.24kb (3.15%) /editor/icons/KeyAudio.svg -- 0.25kb -> 0.24kb (3.15%) /editor/icons/KeyXform.svg -- 0.25kb -> 0.24kb (3.15%) /editor/icons/EditInternal.svg -- 0.28kb -> 0.27kb (3.13%) /editor/icons/GuiChecked.svg -- 0.55kb -> 0.54kb (3%) /editor/icons/BezierHandlesBalanced.svg -- 1.50kb -> 1.46kb (2.99%) /editor/icons/BezierHandlesFree.svg -- 1.63kb -> 1.58kb (2.93%) /editor/icons/GuiToggleOn.svg -- 0.28kb -> 0.27kb (2.81%) /editor/icons/GuiProgressBar.svg -- 0.31kb -> 0.31kb (2.8%) /editor/icons/RectangleShape2D.svg -- 0.23kb -> 0.22kb (2.54%) /editor/icons/NavigationObstacle2D.svg -- 0.32kb -> 0.31kb (2.42%) /modules/gdnative/icons/NativeScript.svg -- 0.70kb -> 0.68kb (2.38%) /modules/gdnative/icons/GDNativeLibrary.svg -- 0.71kb -> 0.69kb (2.34%) /editor/icons/RemoveInternal.svg -- 0.39kb -> 0.38kb (2.23%) /editor/icons/DebugSkipBreakpointsOff.svg -- 0.54kb -> 0.53kb (2.17%) /modules/gdscript/icons/GDScript.svg -- 0.77kb -> 0.75kb (2.16%) /editor/icons/DebugSkipBreakpointsOn.svg -- 0.70kb -> 0.69kb (2.09%) /editor/icons/PlayTravel.svg -- 0.71kb -> 0.69kb (2.08%) /editor/icons/NavigationAgent2D.svg -- 0.39kb -> 0.38kb (2.01%) /editor/icons/GuiScrollArrowRight.svg -- 0.44kb -> 0.43kb (2%) /editor/icons/GuiScrollArrowLeft.svg -- 0.44kb -> 0.43kb (2%) /editor/icons/Crosshair.svg -- 0.35kb -> 0.34kb (1.69%) /editor/icons/KeyHover.svg -- 0.24kb -> 0.23kb (1.66%) /editor/icons/KeyBezierPoint.svg -- 0.24kb -> 0.23kb (1.64%) /editor/icons/KeyBezierSelected.svg -- 0.24kb -> 0.23kb (1.64%) /modules/opensimplex/icons/NoiseTexture.svg -- 0.32kb -> 0.32kb (1.51%) /editor/icons/SoftBody3D.svg -- 0.22kb -> 0.21kb (1.35%) /editor/icons/ProjectIconLoading.svg -- 0.23kb -> 0.23kb (1.28%) /editor/icons/CylinderMesh.svg -- 1.09kb -> 1.08kb (1.26%) /editor/icons/RayCast3D.svg -- 0.16kb -> 0.16kb (1.23%) /editor/icons/StringName.svg -- 0.48kb -> 0.47kb (1.22%) /modules/csg/icons/CSGCylinder3D.svg -- 1.68kb -> 1.66kb (1.22%) /editor/icons/Hsize.svg -- 0.17kb -> 0.17kb (1.16%) /editor/icons/Ruler.svg -- 0.17kb -> 0.17kb (1.12%) /editor/icons/Position3D.svg -- 0.18kb -> 0.18kb (1.06%) /editor/icons/Position2D.svg -- 0.18kb -> 0.18kb (1.06%) /editor/icons/ZoomLess.svg -- 0.40kb -> 0.39kb (0.98%) /editor/icons/YSort.svg -- 0.20kb -> 0.20kb (0.97%) /editor/icons/Navigation2D.svg -- 0.21kb -> 0.21kb (0.93%) /editor/icons/ZoomMore.svg -- 0.42kb -> 0.41kb (0.93%) /editor/icons/Navigation3D.svg -- 0.21kb -> 0.21kb (0.93%) /editor/icons/Rect2i.svg -- 0.42kb -> 0.42kb (0.93%) /editor/icons/TrackAddKeyHl.svg -- 0.22kb -> 0.21kb (0.9%) /editor/icons/GrooveJoint2D.svg -- 0.22kb -> 0.22kb (0.9%) /editor/icons/EditorInternalHandle.svg -- 0.22kb -> 0.22kb (0.89%) /editor/icons/Editor3DHandle.svg -- 0.22kb -> 0.22kb (0.89%) /editor/icons/EditorHandle.svg -- 0.22kb -> 0.22kb (0.89%) /editor/icons/Quad.svg -- 0.22kb -> 0.22kb (0.88%) /editor/icons/LockViewport.svg -- 0.45kb -> 0.44kb (0.88%) /editor/icons/GuiVsplitter.svg -- 0.23kb -> 0.23kb (0.85%) /editor/icons/GuiHsplitter.svg -- 0.23kb -> 0.23kb (0.85%) /editor/icons/Vector2i.svg -- 0.81kb -> 0.80kb (0.84%) /editor/icons/Remove.svg -- 0.23kb -> 0.23kb (0.84%) /editor/icons/DampedSpringJoint2D.svg -- 0.24kb -> 0.23kb (0.83%) /editor/icons/EditorHandleAdd.svg -- 0.24kb -> 0.24kb (0.82%) /editor/icons/GuiSliderGrabber.svg -- 2.05kb -> 2.04kb (0.81%) /editor/icons/Clear.svg -- 0.24kb -> 0.24kb (0.81%) /editor/icons/CollisionShape2D.svg -- 0.24kb -> 0.24kb (0.8%) /editor/icons/MaterialPreviewSphereOff.svg -- 0.24kb -> 0.24kb (0.8%) /editor/icons/GuiViewportVhsplitter.svg -- 0.25kb -> 0.25kb (0.78%) /editor/icons/CollisionPolygon3D.svg -- 0.25kb -> 0.25kb (0.78%) /editor/icons/CollisionPolygon2D.svg -- 0.25kb -> 0.25kb (0.78%) /editor/icons/EditorPivot.svg -- 0.25kb -> 0.25kb (0.78%) /editor/icons/AutoKey.svg -- 0.38kb -> 0.38kb (0.77%) /editor/icons/CollisionShape3D.svg -- 0.25kb -> 0.25kb (0.77%) /editor/icons/ZoomReset.svg -- 0.51kb -> 0.51kb (0.76%) /editor/icons/Vector3i.svg -- 0.89kb -> 0.89kb (0.76%) /editor/icons/GuiViewportHdiagsplitter.svg -- 0.26kb -> 0.25kb (0.76%) /editor/icons/ProxyTexture.svg -- 0.26kb -> 0.26kb (0.76%) /editor/icons/GuiResizer.svg -- 0.26kb -> 0.26kb (0.76%) /editor/icons/Node3D.svg -- 0.26kb -> 0.26kb (0.76%) /editor/icons/Portal.svg -- 0.26kb -> 0.26kb (0.76%) /modules/visual_script/icons/VisualScript.svg -- 0.78kb -> 0.77kb (0.76%) /editor/icons/GuiViewportVdiagsplitter.svg -- 0.26kb -> 0.26kb (0.75%) /editor/icons/LargeTexture.svg -- 0.26kb -> 0.26kb (0.75%) /editor/icons/Grid.svg -- 0.27kb -> 0.27kb (0.73%) /editor/icons/ImageTexture.svg -- 0.27kb -> 0.27kb (0.73%) /editor/icons/GuiSliderGrabberHl.svg -- 2.03kb -> 2.02kb (0.67%) /editor/icons/Key.svg -- 0.29kb -> 0.29kb (0.66%) /editor/icons/Snap.svg -- 0.29kb -> 0.29kb (0.66%) /editor/icons/HTTPRequest.svg -- 0.29kb -> 0.29kb (0.66%) /editor/icons/FixedMaterial.svg -- 0.30kb -> 0.29kb (0.66%) /editor/icons/GuiClose.svg -- 0.30kb -> 0.29kb (0.66%) /editor/icons/GuiCloseCustomizable.svg -- 0.30kb -> 0.29kb (0.66%) /editor/icons/OmniLight3D.svg -- 0.30kb -> 0.30kb (0.66%) /editor/icons/Light2D.svg -- 0.30kb -> 0.30kb (0.66%) /modules/csg/icons/CSGMesh3D.svg -- 0.92kb -> 0.91kb (0.64%) /editor/icons/SnapGrid.svg -- 0.31kb -> 0.31kb (0.63%) /editor/icons/GuiTabMenu.svg -- 0.31kb -> 0.31kb (0.62%) /editor/icons/GuiTab.svg -- 0.32kb -> 0.32kb (0.61%) /editor/icons/EditResource.svg -- 0.33kb -> 0.32kb (0.6%) /editor/icons/StreamTexture.svg -- 0.33kb -> 0.33kb (0.59%) /editor/icons/Search.svg -- 0.33kb -> 0.33kb (0.59%) /editor/icons/ViewportSpeed.svg -- 1.67kb -> 1.66kb (0.58%) /editor/icons/Image.svg -- 0.34kb -> 0.33kb (0.58%) /editor/icons/GroupViewport.svg -- 0.68kb -> 0.67kb (0.58%) /modules/csg/icons/CSGCapsule3D.svg -- 1.02kb -> 1.02kb (0.57%) /editor/icons/AnimatedSprite3D.svg -- 0.69kb -> 0.69kb (0.56%) /editor/icons/AnimatedSprite2D.svg -- 0.69kb -> 0.69kb (0.56%) /modules/csg/icons/CSGSphere3D.svg -- 1.04kb -> 1.04kb (0.56%) /editor/icons/ArrowLeft.svg -- 0.36kb -> 0.35kb (0.55%) /editor/icons/ArrowRight.svg -- 0.36kb -> 0.35kb (0.55%) /editor/icons/ParallaxBackground.svg -- 0.36kb -> 0.36kb (0.55%) /editor/icons/GuiVisibilityXray.svg -- 0.71kb -> 0.71kb (0.55%) /editor/icons/LightOccluder2D.svg -- 0.36kb -> 0.36kb (0.54%) /editor/icons/GizmoLight.svg -- 0.73kb -> 0.72kb (0.54%) /editor/icons/Blend.svg -- 0.37kb -> 0.36kb (0.53%) /editor/icons/ToolPan.svg -- 0.37kb -> 0.37kb (0.53%) /editor/icons/ShortCut.svg -- 0.37kb -> 0.37kb (0.52%) /editor/icons/KeyNext.svg -- 0.38kb -> 0.38kb (0.52%) /editor/icons/SpotLight3D.svg -- 0.38kb -> 0.38kb (0.52%) /modules/mono/icons/CSharpScript.svg -- 0.97kb -> 0.96kb (0.51%) /editor/icons/GuiOptionArrow.svg -- 0.39kb -> 0.39kb (0.5%) /editor/icons/PackedInt64Array.svg -- 0.39kb -> 0.39kb (0.5%) /editor/icons/PackedInt32Array.svg -- 0.39kb -> 0.39kb (0.5%) /editor/icons/ReflectionProbe.svg -- 0.39kb -> 0.39kb (0.5%) /editor/icons/Zoom.svg -- 0.40kb -> 0.39kb (0.49%) /editor/icons/TouchScreenButton.svg -- 0.40kb -> 0.39kb (0.49%) /editor/icons/StaticBody3D.svg -- 0.40kb -> 0.40kb (0.49%) /editor/icons/CopyNodePath.svg -- 0.40kb -> 0.40kb (0.49%) /editor/icons/ArrowDown.svg -- 0.40kb -> 0.40kb (0.49%) /editor/icons/Loop.svg -- 0.40kb -> 0.40kb (0.49%) /editor/icons/ArrowUp.svg -- 0.41kb -> 0.41kb (0.48%) /editor/icons/GIProbe.svg -- 0.41kb -> 0.41kb (0.48%) /editor/icons/PinJoint2D.svg -- 0.41kb -> 0.41kb (0.48%) /editor/icons/PackedFloat64Array.svg -- 0.42kb -> 0.41kb (0.47%) /editor/icons/PackedFloat32Array.svg -- 0.42kb -> 0.41kb (0.47%) /editor/icons/Transform.svg -- 0.42kb -> 0.42kb (0.47%) /editor/icons/ScriptCreateDialog.svg -- 1.27kb -> 1.26kb (0.46%) /editor/icons/ListSelect.svg -- 0.43kb -> 0.42kb (0.46%) /editor/icons/AddSplit.svg -- 0.43kb -> 0.43kb (0.45%) /editor/icons/TileMap.svg -- 0.44kb -> 0.43kb (0.45%) /editor/icons/Decal.svg -- 0.66kb -> 0.66kb (0.44%) /editor/icons/PackedStringArray.svg -- 0.44kb -> 0.44kb (0.44%) /editor/icons/LoopInterpolation.svg -- 0.45kb -> 0.45kb (0.44%) /editor/icons/EditorPlugin.svg -- 0.45kb -> 0.45kb (0.43%) /editor/icons/FileMediumThumb.svg -- 0.45kb -> 0.45kb (0.43%) /editor/icons/GPUParticles3D.svg -- 0.46kb -> 0.46kb (0.43%) /editor/icons/CanvasItem.svg -- 0.47kb -> 0.46kb (0.42%) /editor/icons/PackedByteArray.svg -- 0.47kb -> 0.47kb (0.42%) /editor/icons/FileBigThumb.svg -- 0.47kb -> 0.47kb (0.41%) /editor/icons/ToolScale.svg -- 0.48kb -> 0.48kb (0.41%) /editor/icons/DirectionalLight3D.svg -- 0.49kb -> 0.48kb (0.4%) /editor/icons/Viewport.svg -- 0.49kb -> 0.48kb (0.4%) /editor/icons/Quat.svg -- 0.49kb -> 0.48kb (0.4%) /editor/icons/MaterialPreviewLight1Off.svg -- 0.49kb -> 0.49kb (0.4%) /editor/icons/GuiVisibilityVisible.svg -- 0.49kb -> 0.49kb (0.4%) /editor/icons/Room.svg -- 0.50kb -> 0.50kb (0.39%) /editor/icons/VehicleBody3D.svg -- 0.50kb -> 0.50kb (0.39%) /editor/icons/Issue.svg -- 0.75kb -> 0.75kb (0.39%) /editor/icons/MoveDown.svg -- 0.51kb -> 0.51kb (0.38%) /editor/icons/MoveUp.svg -- 0.51kb -> 0.51kb (0.38%) /editor/icons/Joypad.svg -- 0.51kb -> 0.51kb (0.38%) /editor/icons/MoveRight.svg -- 0.51kb -> 0.51kb (0.38%) /editor/icons/MeshInstance3D.svg -- 0.51kb -> 0.51kb (0.38%) /editor/icons/GuiMiniCheckerboard.svg -- 0.26kb -> 0.26kb (0.38%) /editor/icons/MoveLeft.svg -- 0.52kb -> 0.51kb (0.38%) /editor/icons/MirrorY.svg -- 0.52kb -> 0.51kb (0.38%) /editor/icons/Basis.svg -- 0.52kb -> 0.52kb (0.38%) /editor/icons/VisibilityNotifier3D.svg -- 0.52kb -> 0.52kb (0.38%) /editor/icons/Group.svg -- 0.52kb -> 0.52kb (0.38%) /editor/icons/GuiVisibilityHidden.svg -- 0.52kb -> 0.52kb (0.38%) /editor/icons/GuiTreeUpdown.svg -- 0.52kb -> 0.52kb (0.37%) /editor/icons/GuiSpinboxUpdown.svg -- 0.52kb -> 0.52kb (0.37%) /editor/icons/GuiEllipsis.svg -- 0.52kb -> 0.52kb (0.37%) /editor/icons/PathFollow2D.svg -- 0.53kb -> 0.52kb (0.37%) /editor/icons/PathFollow3D.svg -- 0.53kb -> 0.52kb (0.37%) /editor/icons/ToolRotate.svg -- 0.53kb -> 0.53kb (0.37%) /editor/icons/Skeleton3D.svg -- 0.53kb -> 0.53kb (0.37%) /editor/icons/ParallaxLayer.svg -- 0.54kb -> 0.53kb (0.36%) /editor/icons/ViewportTexture.svg -- 0.54kb -> 0.54kb (0.36%) /editor/icons/TestCube.svg -- 0.56kb -> 0.55kb (0.35%) /editor/icons/VisibilityEnabler3D.svg -- 0.56kb -> 0.56kb (0.35%) /editor/icons/VisibilityEnabler2D.svg -- 0.56kb -> 0.56kb (0.35%) /editor/icons/VehicleWheel3D.svg -- 0.57kb -> 0.57kb (0.34%) /editor/icons/ProximityGroup3D.svg -- 0.57kb -> 0.57kb (0.34%) /editor/icons/SubViewport.svg -- 0.87kb -> 0.87kb (0.34%) /editor/icons/Path3D.svg -- 0.58kb -> 0.58kb (0.34%) /editor/icons/Path2D.svg -- 0.58kb -> 0.58kb (0.34%) /editor/icons/Vector2.svg -- 0.59kb -> 0.59kb (0.33%) /editor/icons/PackedVector2Array.svg -- 0.59kb -> 0.59kb (0.33%) /editor/icons/EditorControlAnchor.svg -- 0.60kb -> 0.60kb (0.32%) /editor/icons/EditorPositionPrevious.svg -- 0.61kb -> 0.61kb (0.32%) /editor/icons/Bone.svg -- 0.62kb -> 0.62kb (0.31%) /editor/icons/CanvasLayer.svg -- 0.63kb -> 0.62kb (0.31%) /editor/icons/AABB.svg -- 0.63kb -> 0.63kb (0.31%) /editor/icons/CameraTexture.svg -- 0.63kb -> 0.63kb (0.31%) /editor/icons/Vector3.svg -- 0.63kb -> 0.63kb (0.31%) /editor/icons/MultiMeshInstance3D.svg -- 0.64kb -> 0.63kb (0.31%) /editor/icons/ToolMove.svg -- 0.65kb -> 0.64kb (0.3%) /editor/icons/Unbone.svg -- 0.65kb -> 0.65kb (0.3%) /editor/icons/KeyRotation.svg -- 0.66kb -> 0.65kb (0.3%) /editor/icons/Transform2D.svg -- 0.67kb -> 0.67kb (0.29%) /editor/icons/RemoteTransform2D.svg -- 0.70kb -> 0.69kb (0.28%) /editor/icons/CurveTexture.svg -- 0.71kb -> 0.71kb (0.27%) /editor/icons/KeyPosition.svg -- 0.72kb -> 0.72kb (0.27%) /editor/icons/NavigationRegion3D.svg -- 1.15kb -> 1.15kb (0.25%) /editor/icons/KeyScale.svg -- 0.78kb -> 0.77kb (0.25%) /editor/icons/KinematicBody3D.svg -- 0.78kb -> 0.78kb (0.25%) /editor/icons/HelpSearch.svg -- 0.80kb -> 0.80kb (0.24%) /editor/icons/EditorPositionUnselected.svg -- 0.83kb -> 0.82kb (0.24%) /editor/icons/PackedVector3Array.svg -- 0.83kb -> 0.83kb (0.24%) /editor/icons/EditorPosition.svg -- 0.84kb -> 0.83kb (0.23%) /editor/icons/MaterialPreviewLight2Off.svg -- 0.92kb -> 0.91kb (0.21%) /editor/icons/MeshTexture.svg -- 0.95kb -> 0.95kb (0.21%) /editor/icons/GizmoCPUParticles3D.svg -- 2.86kb -> 2.86kb (0.2%) /modules/csg/icons/CSGPolygon3D.svg -- 1.58kb -> 1.58kb (0.19%) /modules/csg/icons/CSGTorus3D.svg -- 1.67kb -> 1.67kb (0.18%) /editor/icons/GizmoSpotLight.svg -- 1.71kb -> 1.70kb (0.17%) /editor/icons/NavigationRegion2D.svg -- 1.21kb -> 1.21kb (0.16%) /editor/icons/GizmoDirectionalLight.svg -- 2.84kb -> 2.83kb (0.14%) /editor/icons/WorldEnvironment.svg -- 1.60kb -> 1.60kb (0.12%) /editor/icons/CPUParticles3D.svg -- 2.64kb -> 2.64kb (0.11%) /editor/icons/CPUParticles2D.svg -- 2.64kb -> 2.64kb (0.11%) /editor/icons/RichTextEffect.svg -- 0.89kb -> 0.89kb (0.11%) /editor/icons/RigidBody2D.svg -- 1.79kb -> 1.79kb (0.11%) /editor/icons/RigidBody3D.svg -- 1.89kb -> 1.89kb (0.1%) /editor/icons/GizmoGIProbe.svg -- 2.16kb -> 2.16kb (0.09%) /editor/icons/GizmoBakedLightmap.svg -- 2.22kb -> 2.22kb (0.09%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
Calinou
pushed a commit
that referenced
this pull request
Aug 13, 2022
Calinou
pushed a commit
that referenced
this pull request
Aug 13, 2022
[doc] Use "param" instead of "code" to refer to parameters #3
Calinou
pushed a commit
that referenced
this pull request
Jun 23, 2023
Fixes godotengine#76581. TSAN flagged this issue on starting the editor: 1. main calls register_core_types, which calls IP::create(), which calls Thread::start on the resolver thread 2. Thread::callback calls ScriptServer::thread_enter(), as "Scripts may need to attach a stack." 3. ScriptServer::thread_enter() accesses ScriptServer::_languages, which is still being initialized on the main thread by initialize_gdscript_module This fixes the issue by skipping thread enter/exit notifications if languages have not finished initializing yet. I'm assuming that notifying un-initialized languages of thread starts/stops would have been pointless anyways. If we need to somehow notify languages of threads before the languages initialize, we'll need a different solution. ``` Godot Engine v4.0.2.stable.custom_build.7a0977ce2 - https://godotengine.org ================== WARNING: ThreadSanitizer: data race (pid=9426) Write of size 4 at 0x55615b187cd0 by main thread: #0 ScriptServer::register_language(ScriptLanguage*) /home/rcorre/src/godot/godot/core/object/script_language.cpp:177:28 (godot.linuxbsd.editor.x86_64.llvm.san+0x9e52ab9) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #1 initialize_gdscript_module(ModuleInitializationLevel) /home/rcorre/src/godot/godot/modules/gdscript/register_types.cpp:118:3 (godot.linuxbsd.editor.x86_64.llvm.san+0x36f9c6f) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #2 initialize_modules(ModuleInitializationLevel) /home/rcorre/src/godot/godot/modules/register_module_types.gen.cpp:93:2 (godot.linuxbsd.editor.x86_64.llvm.san+0x2f50499) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #3 Main::setup2(unsigned long) /home/rcorre/src/godot/godot/main/main.cpp:1961:2 (godot.linuxbsd.editor.x86_64.llvm.san+0x2f1d40d) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #4 Main::setup(char const*, int, char**, bool) /home/rcorre/src/godot/godot/main/main.cpp:1879:10 (godot.linuxbsd.editor.x86_64.llvm.san+0x2f16370) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #5 main /home/rcorre/src/godot/godot/platform/linuxbsd/godot_linuxbsd.cpp:61:14 (godot.linuxbsd.editor.x86_64.llvm.san+0x2e67e1f) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) Previous read of size 4 at 0x55615b187cd0 by thread T1: #0 ScriptServer::thread_enter() /home/rcorre/src/godot/godot/core/object/script_language.cpp:244:22 (godot.linuxbsd.editor.x86_64.llvm.san+0x9e54aed) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #1 Thread::callback(unsigned long, Thread::Settings const&, void (*)(void*), void*) /home/rcorre/src/godot/godot/core/os/thread.cpp:61:2 (godot.linuxbsd.editor.x86_64.llvm.san+0x9464ab0) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #2 void std::__invoke_impl<void, void (*)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long, Thread::Settings, void (*)(void*), void*>(std::__invoke_other, void (*&&)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long&&, Thread::Settings&&, void (*&&)(void*), void*&&) /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1/../../../../include/c++/12.2.1/bits/invoke.h:61:14 (godot.linuxbsd.editor.x86_64.llvm.san+0x9465283) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #3 std::__invoke_result<void (*)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long, Thread::Settings, void (*)(void*), void*>::type std::__invoke<void (*)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long, Thread::Settings, void (*)(void*), void*>(void (*&&)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long&&, Thread::Settings&&, void (*&&)(void*), void*&&) /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1/../../../../include/c++/12.2.1/bits/invoke.h:96:14 (godot.linuxbsd.editor.x86_64.llvm.san+0x9465283) #4 void std::thread::_Invoker<std::tuple<void (*)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long, Thread::Settings, void (*)(void*), void*>>::_M_invoke<0ul, 1ul, 2ul, 3ul, 4ul>(std::_Index_tuple<0ul, 1ul, 2ul, 3ul, 4ul>) /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1/../../../../include/c++/12.2.1/bits/std_thread.h:258:13 (godot.linuxbsd.editor.x86_64.llvm.san+0x9465283) #5 std::thread::_Invoker<std::tuple<void (*)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long, Thread::Settings, void (*)(void*), void*>>::operator()() /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1/../../../../include/c++/12.2.1/bits/std_thread.h:265:11 (godot.linuxbsd.editor.x86_64.llvm.san+0x9465283) #6 std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (*)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long, Thread::Settings, void (*)(void*), void*>>>::_M_run() /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1/../../../../include/c++/12.2.1/bits/std_thread.h:210:13 (godot.linuxbsd.editor.x86_64.llvm.san+0x9465283) #7 execute_native_thread_routine /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++11/thread.cc:82:18 (libstdc++.so.6+0xd72c2) (BuildId: 6fe66a2d539a78c993bd2d377e00fad389220963) Location is global 'ScriptServer::_language_count' of size 4 at 0x55615b187cd0 (godot.linuxbsd.editor.x86_64.llvm.san+0xbf46cd0) Thread T1 (tid=9431, running) created by main thread at: #0 pthread_create <null> (godot.linuxbsd.editor.x86_64.llvm.san+0x2de5776) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #1 __gthread_create /usr/src/debug/gcc/gcc-build/x86_64-pc-linux-gnu/libstdc++-v3/include/x86_64-pc-linux-gnu/bits/gthr-default.h:663:35 (libstdc++.so.6+0xd73a9) (BuildId: 6fe66a2d539a78c993bd2d377e00fad389220963) #2 std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State>>, void (*)()) /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++11/thread.cc:147:37 (libstdc++.so.6+0xd73a9) #3 IP::IP() /home/rcorre/src/godot/godot/core/io/ip.cpp:347:19 (godot.linuxbsd.editor.x86_64.llvm.san+0x962cbcd) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #4 IPUnix::IPUnix() /home/rcorre/src/godot/godot/drivers/unix/ip_unix.cpp:261:9 (godot.linuxbsd.editor.x86_64.llvm.san+0x4aee599) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #5 IPUnix::_create_unix() /home/rcorre/src/godot/godot/drivers/unix/ip_unix.cpp:258:9 (godot.linuxbsd.editor.x86_64.llvm.san+0x4aee599) #6 IP::create() /home/rcorre/src/godot/godot/core/io/ip.cpp:339:9 (godot.linuxbsd.editor.x86_64.llvm.san+0x962ca5e) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #7 register_core_types() /home/rcorre/src/godot/godot/core/register_core_types.cpp:279:7 (godot.linuxbsd.editor.x86_64.llvm.san+0x93e2333) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #8 Main::setup(char const*, int, char**, bool) /home/rcorre/src/godot/godot/main/main.cpp:690:2 (godot.linuxbsd.editor.x86_64.llvm.san+0x2f08a49) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) #9 main /home/rcorre/src/godot/godot/platform/linuxbsd/godot_linuxbsd.cpp:61:14 (godot.linuxbsd.editor.x86_64.llvm.san+0x2e67e1f) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048) SUMMARY: ThreadSanitizer: data race /home/rcorre/src/godot/godot/core/object/script_language.cpp:177:28 in ScriptServer::register_language(ScriptLanguage*) ``` Co-authored-by: Pedro J. Estébanez <RandomShaper@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beep boop. Your images are optimized!
Your image file size has been reduced by 8% 🎉
Details
Black Lives Matter | 💰 donate | 🎓 learn | ✍🏾 sign
📝 docs |
repo | 🙋🏾 issues | 🏅 swag | 🏪 marketplace