Repository navigation
feat: Add unlisted visibility option for event types #236
Replies: 1 comment
|
This is the right idea, and the code backs it up more strongly than the proposal says.
So today those are welded together in about seven call sites, which is exactly why nobody can share a link without advertising it. Splitting them is the fix, and your three states are the right shape. Two implementation notes worth settling before review. First, this is a boolean becoming an enum, so the migration has to be behaviour-preserving: Second, the split has to be explicit at each of those seven sites rather than left to a helper that guesses. Under your model, unlisted is bookable by direct slug and absent from the directory. That means the direct-slug paths allow it, the two directory queries exclude it, and One thing I would add to the proposal. Unlisted is discoverability, not access control, and you already say so. Worth saying it in the admin UI as well, next to the setting, because "unlisted" reads like "secret" to people who have not thought about it and the first support request will be from someone who assumed it was. The draft PR #237 is the right direction. If you tighten it to the migration mapping above and make the three call-site groups explicit, it should review cleanly. |
Uh oh!
There was an error while loading. Please reload this page.
Summary
Add an Unlisted visibility option for event types, allowing administrators to share directly accessible booking pages without including those event types in the public directory.
Currently, Calnode's
Publicsetting controls both whether an event type has an accessible public booking page and whether it appears in the directory. This prevents administrators from offering booking links intended for specific audiences without also advertising those event types publicly.This change separates booking-page accessibility from directory discoverability while preserving existing behavior.
Proposed Behavior
Replace the existing Public checkbox with three visibility options:
Public
Unlisted
Private
The existing Active setting remains independent of visibility. Inactive event types continue to follow their existing booking restrictions.
Use Cases
Unlisted event types support several common scheduling scenarios:
Unlisted visibility is a discoverability feature, not an access-control mechanism. Anyone possessing the direct URL can access the booking page.
Implementation
The intended scope includes:
New event types should default to Public, consistent with current behavior.
Backward Compatibility
Existing event types must retain their behavior after upgrading:
The migration must support upgrades from existing Calnode installations and follow the repository's established migration conventions.
Testing
The implementation should include regression coverage for:
Scope
This change is intentionally limited to event-type visibility and directory discoverability.
It does not introduce:
All reactions