Clean up configurability handling and docs #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @thomasjm |
thomasjm
reviewed
May 10, 2019
| ------------- | ||
| ``Metakernel`` subclasses can be configured by the user by adding a ``metakernel_config.py`` file to their | ||
| ``jupyter`` config path. The base ``MetaKernel`` class offers ``plot_settings`` as a configurable trait. | ||
| ``Metakernel`` implementations can subclasses can be configured by the user. The |
There was a problem hiding this comment.
Looking good @blink1073! Noticed a couple typos here, should probably change
implementations can subclasses can be configured by the user -> subclasses can be configured by the user
Subclasses can defined -> Subclasses can define
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier for subclasses to provide configurability and update docs.