Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package.json: replaces prepublish script to prepare #208

Merged
merged 1 commit into from
Feb 8, 2020

Conversation

sgobotta
Copy link
Member

@sgobotta sgobotta commented Feb 8, 2020

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

  • Npm script update: prepublish -> prepare

Closes #28
Closes #185

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sgobotta sgobotta added the enhancement New feature or request label Feb 8, 2020
@codecov-io
Copy link

codecov-io commented Feb 8, 2020

Codecov Report

Merging #208 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #208   +/-   ##
========================================
  Coverage    42.24%   42.24%           
========================================
  Files           94       94           
  Lines          748      748           
  Branches        30       30           
========================================
  Hits           316      316           
  Misses         429      429           
  Partials         3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eabbfc...9f8a8eb. Read the comment docs.

@sgobotta sgobotta merged commit b8b72b9 into develop Feb 8, 2020
@sgobotta sgobotta deleted the 185-Update-npm-prepublish-script-to-prepare branch February 8, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants