42 simple api injection proposal for custom user componentisation #43

sgobotta · 2018-12-24T23:40:55Z

This PR provides:

An implementation of a simple API injection for any custom component to be used in forms, to update, create and submit data

Closes #42

+ Vuetify update was needed to render some new components + Vue was updated since Vuetify needed it's latest version

…posal

…e view should show

…om prop + A testing route that simulates the Create View has been added to Resource

+ Resource will inject props to the CustomCreate component that a user passes + CustomCreate should use those functions to update and submit a custom form

+ Updated and documented CustomCreate component + Updates Resource to use the new binding function for the CreateTest view + Entities store: refactors the key name + Documented and refactored the store utils

+ This is specially used when you have to redirect to a show view and you don't know where the id is in the response after a create Action

…om-user-componentisation

sgobotta · 2019-01-08T17:00:03Z

Summary

Pull Request Deliverables:

A new Resource in the App demo with 4 custom components: MagazinesList, MagazinesShow, MagazinesCreate, MagazinesEdit
Resource support to use either default components (the way we used to use them, with an array of attributes) and custom components.
Resource binding functions refactor, resource utilities have been created
Creation of an entities store to maintain the state of custom components services, with it's own utilities for each view (list, show, create, edit)
Aliases usage for import statement routes along the project.
Tests
- Added utilities and custom cypress commands for easily implement e2e tests
- Created magazines tests for list, show, create, edit.

…ed to functions

estefi-prieto · 2019-01-09T18:58:36Z

src/components/Resource/src/binding.utils.js

+        // list is a user's custom component
+        const utils = listUtils({
+          resourceName,
+          router,


The listUtils function doesn't use the router parameter. We need to remove it.

Alright, fixed in 46afb88

estefi-prieto · 2019-01-09T19:26:19Z

tests/e2e/specs/magazines/list.spec.js

+
+  let timesNavigatedToNextPage = 0
+
+  before('Creates a new magazine', () => {


The description doesn't match the setup content

Fixed in 85ab70a

…nd subpaths

+ Articles tests have been restructured

sgobotta added 13 commits December 24, 2018 03:38

Updates Vue and Vuetify to their latest versions

8bb5424

+ Vuetify update was needed to render some new components + Vue was updated since Vuetify needed it's latest version

Created some wrapper components for testing the functional render pro…

776581c

…posal

Creates a store to persist forms data

2a17ee5

Admin initializes the form store

94e25b4

As a User, creates a CustomCreate component that defines what a Creat…

9d6c6ff

…e view should show

As a User, CustomCreate component is used in the App module in a cust…

fd25a86

…om prop + A testing route that simulates the Create View has been added to Resource

Fixes the articles delete service

733c5cd

Moved the store modules to a new directory

3407c64

Admin: updates the store modules import

bc638e3

Refactored CustomCreate and Resource for decoupling:

2164bd0

+ Resource will inject props to the CustomCreate component that a user passes + CustomCreate should use those functions to update and submit a custom form

Deletes old store directory

e39189f

Custom Component usage: refactor

722a438

+ Updated and documented CustomCreate component + Updates Resource to use the new binding function for the CreateTest view + Entities store: refactors the key name + Documented and refactored the store utils

Creates a demo directory for the App and custom components

ce9b53d

sgobotta requested a review from josx December 24, 2018 23:41

sgobotta and others added 15 commits December 25, 2018 20:38

Creates store utils for editing

72dce9a

Refactors entities store and utils

972f798

Resource: Implements binding for custom Edit components

ee8dc54

Creates an EditMagazines custom component

85b8534

Adds the EditMagazines component to App

e1a6aa5

Renames the custom Create component

e3aa39f

Added some FIXME comments

45c32e6

demo/App: Updates comments

5354974

Fixes a server service when there is no data available

3f3142e

Adds parseResponse functionality to the store utils

1b85d57

+ This is specially used when you have to redirect to a show view and you don't know where the id is in the response after a create Action

Resource: the parseResponses object is passed to the store utils

d12bb97

Deleted unnecessary parameter

c272ef5

Refactored the initial state of the entities store

8249c5b

Refactored the edit and create utils

e9bcb50

Merge branch 'develop' into 42-simple-api-injection-proposal-for-cust…

d7335c6

…om-user-componentisation

sgobotta added this to Needs review in Current Tasks Jan 4, 2019

sgobotta added 7 commits January 7, 2019 22:08

Creates a Magazines List component

3f892e8

Resource: now accepts a list component as an array or Object

4ee4f01

App: magazines resource uses the new List custom component

214399d

Tests: adds a getTableRow command

b7538cc

Magazine List: Adds name property to the rows

33ab3b1

Adds a test for the Magazines List

3ada835

Fixes some types and add a FIXME note

7755779

sgobotta mentioned this pull request Jan 8, 2019

Create demo App directory #17

Closed

sgobotta added 5 commits January 8, 2019 10:51

Refactored the Magazines List test

a476bb7

Adds comment for the e2e lib commands

4adbb0c

Fix types on command comments

315766d

Updates to develop

912a908

Updates import declarations using the webpack config @Aliases

798303e

sgobotta added 2 commits January 8, 2019 14:07

Cypress theme support

a80bb4d

Resource utils: removed redundant check for undefined components pass…

9077f47

…ed to functions

estefi-prieto reviewed Jan 9, 2019

View reviewed changes

Removed router parameter from the listUtils functions

46afb88

estefi-prieto reviewed Jan 9, 2019

View reviewed changes

sgobotta added 8 commits January 9, 2019 16:44

Fixes the magazines test setup description

85ab70a

Test lib: creates a utility function to query urls by resource name a…

ffbbe31

…nd subpaths

Magazine List test: refactored the iteration part of the tests

862adf1

Removed extra button in the Magazines List

856c883

Refactors the RESOURCE_ID_EDIT_BUTTON constant

bff9020

Refactors createUrlWithResource function

116339c

Fixes edit and show tests

95c2f63

Adds cypress wait function to some tests

aebf3f6

+ Articles tests have been restructured

estefi-prieto merged commit 9fcf4da into develop Jan 10, 2019

Current Tasks automation moved this from Needs review to Done Jan 10, 2019

sgobotta deleted the 42-simple-api-injection-proposal-for-custom-user-componentisation branch January 11, 2019 00:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

42 simple api injection proposal for custom user componentisation #43

42 simple api injection proposal for custom user componentisation #43

sgobotta commented Dec 24, 2018 •

edited

sgobotta commented Jan 8, 2019

estefi-prieto Jan 9, 2019 •

edited

sgobotta Jan 9, 2019 •

edited

estefi-prieto Jan 9, 2019

sgobotta Jan 9, 2019


		let timesNavigatedToNextPage = 0

		before('Creates a new magazine', () => {

42 simple api injection proposal for custom user componentisation #43

42 simple api injection proposal for custom user componentisation #43

Conversation

sgobotta commented Dec 24, 2018 • edited

sgobotta commented Jan 8, 2019

Summary

Pull Request Deliverables:

estefi-prieto Jan 9, 2019 • edited

Choose a reason for hiding this comment

sgobotta Jan 9, 2019 • edited

Choose a reason for hiding this comment

estefi-prieto Jan 9, 2019

Choose a reason for hiding this comment

sgobotta Jan 9, 2019

Choose a reason for hiding this comment

sgobotta commented Dec 24, 2018 •

edited

estefi-prieto Jan 9, 2019 •

edited

sgobotta Jan 9, 2019 •

edited