Skip to content

cancel cursor actor on drop #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

cancel cursor actor on drop #1041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/recording/src/cursor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use cap_project::{CursorClickEvent, CursorMoveEvent, XY};
use cap_timestamp::Timestamps;
use std::{collections::HashMap, path::PathBuf};
use tokio::sync::oneshot;
use tokio_util::sync::CancellationToken;
use tokio_util::sync::{CancellationToken, DropGuard};

pub struct Cursor {
pub file_name: String,
Expand All @@ -24,13 +24,13 @@ pub struct CursorActorResponse {
}

pub struct CursorActor {
stop: CancellationToken,
stop: DropGuard,
rx: oneshot::Receiver<CursorActorResponse>,
}

impl CursorActor {
pub async fn stop(self) -> CursorActorResponse {
self.stop.cancel();
drop(self.stop);
self.rx.await.unwrap()
}
}
Expand Down Expand Up @@ -180,7 +180,7 @@ pub fn spawn_cursor_recorder(
});

CursorActor {
stop: stop_token,
stop: stop_token.drop_guard(),
rx,
}
}
Expand Down
Loading