Skip to content

Prewarm new recording picker thumbnails on window init #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
+27 −10
Merged

Prewarm new recording picker thumbnails on window init #1125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions apps/desktop/src/routes/(window-chrome)/new-main/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,26 +318,45 @@ function Page() {

const displayTargets = useQuery(() => ({
...listDisplaysWithThumbnails,
enabled: hasOpenedDisplayMenu(),
refetchInterval: false,
}));

const windowTargets = useQuery(() => ({
...listWindowsWithThumbnails,
enabled: hasOpenedWindowMenu(),
refetchInterval: false,
}));

const screens = useQuery(() => listScreens);
const windows = useQuery(() => listWindows);

const hasDisplayTargetsData = () => displayTargets.status === "success";
const hasWindowTargetsData = () => windowTargets.status === "success";

const displayTargetsData = createMemo(() =>
hasDisplayTargetsData() ? displayTargets.data : undefined,
);
const existingDisplayIds = createMemo(() => {
const currentScreens = screens.data;
if (!currentScreens) return undefined;
return new Set(currentScreens.map((screen) => screen.id));
});

const windowTargetsData = createMemo(() =>
hasWindowTargetsData() ? windowTargets.data : undefined,
);
const displayTargetsData = createMemo(() => {
if (!hasDisplayTargetsData()) return undefined;
const ids = existingDisplayIds();
if (!ids) return displayTargets.data;
return displayTargets.data?.filter((target) => ids.has(target.id));
});

const existingWindowIds = createMemo(() => {
const currentWindows = windows.data;
if (!currentWindows) return undefined;
return new Set(currentWindows.map((win) => win.id));
});

const windowTargetsData = createMemo(() => {
if (!hasWindowTargetsData()) return undefined;
const ids = existingWindowIds();
if (!ids) return windowTargets.data;
return windowTargets.data?.filter((target) => ids.has(target.id));
});

const displayMenuLoading = () =>
!hasDisplayTargetsData() &&
Expand Down Expand Up @@ -430,8 +449,6 @@ function Page() {
else commands.closeTargetSelectOverlays();
});

const screens = useQuery(() => listScreens);
const windows = useQuery(() => listWindows);
const cameras = useQuery(() => listVideoDevices);
const mics = useQuery(() => listAudioDevices);

Expand Down