Skip to content

Conversation

p-delorme
Copy link
Contributor

@p-delorme p-delorme commented Oct 8, 2025

The camera window had a hardcoded minimum size of (460, 920), which prevented the TypeScript code from dynamically sizing the window.

Now when you restart the app and toggle the camera on/off, it should stay at the correct size instead of growing to 460x920

Summary by CodeRabbit

  • New Features

    • Camera window can now be resized to a smaller minimum size (200x200), enabling more flexible layouts and better usability on small screens.
    • Improved window behavior on creation and resize, allowing the Camera window to fit alongside other apps or panels more easily.
  • Chores

    • Internal adjustments to window sizing logic with no changes to public interfaces.

Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Walkthrough

Adjusted the minimum inner size for the Camera window in CapWindowId::min_size from (460.0, 920.0) to (200.0, 200.0). No other logic, control flow, or public API signatures were changed.

Changes

Cohort / File(s) Change summary
Window sizing
apps/desktop/src-tauri/src/windows.rs
Updated CapWindowId::Camera min_size from (460.0, 920.0) to (200.0, 200.0); other match arms unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I nudge the panes, small as a seed,
A window shrinks to meet the need.
From towering frames to tidy view,
A hop, a tweak—now nimble too.
Thump-thump! goes change beneath my feet,
Compact as clover, crisp and neat. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title concisely and accurately summarizes the primary behavior change by indicating that the camera window’s initial size has been reduced, which directly corresponds to the code modification adjusting the minimum dimensions from 460×920 to 200×200.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd2e001 and 6789e33.

📒 Files selected for processing (1)
  • apps/desktop/src-tauri/src/windows.rs (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx,js,jsx,rs}

📄 CodeRabbit inference engine (CLAUDE.md)

Do not add inline, block, or docstring comments in any language; code must be self-explanatory

Files:

  • apps/desktop/src-tauri/src/windows.rs
**/*.rs

📄 CodeRabbit inference engine (AGENTS.md)

**/*.rs: Format Rust code using rustfmt and ensure all Rust code passes workspace-level clippy lints.
Rust modules should be named with snake_case, and crate directories should be in kebab-case.

Files:

  • apps/desktop/src-tauri/src/windows.rs
🧬 Code graph analysis (1)
apps/desktop/src-tauri/src/windows.rs (1)
apps/desktop/src/utils/tauri.ts (1)
  • Camera (353-353)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build Desktop (x86_64-pc-windows-msvc, windows-latest)
  • GitHub Check: Build Desktop (aarch64-apple-darwin, macos-latest)
🔇 Additional comments (1)
apps/desktop/src-tauri/src/windows.rs (1)

171-171: LGTM – reduced camera window min size enables dynamic sizing
Change from (460.0, 920.0) to (200.0, 200.0) satisfies the PR objective. Verify that the TypeScript layer (e.g. in mode-select.tsx and window-chrome/main.tsx) uses window.setSize to set and persist the camera window size across restarts and mode toggles.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Brendonovich Brendonovich merged commit db748d0 into CapSoftware:main Oct 9, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants