Sort table view columns alphabetically #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 18, 2015 11:03
Secondary to predefined priorities
Test didn’t actually passed when run in browser, re-implemented sort comparison to work as desired and expected
|
@javisantana ok? |
| @@ -178,8 +178,8 @@ | |||
| return name && name.replace(/"/g, ''); | |||
| }, | |||
|
|
|||
| sortSchema: function(priorities) { | |||
| this.set('schema', cdb.admin.CartoDBTableMetadata.sortSchema(this.get('schema'), priorities)); | |||
There was a problem hiding this comment.
why did you remove the param?
There was a problem hiding this comment.
- Removed the optional priorities param since it was not used anywhere
There was a problem hiding this comment.
I mean, I'm probably agree, but not sure why I did that, probably we were using that param at some point from somewhere
There was a problem hiding this comment.
Yeah, I figured, in general I think it's better to remove unused code when doing changes though than leaving it around "just in case" :)
|
🇪🇸 |
|
Frontend tests were OK 👍 (details) |
viddo
added a commit
that referenced
this pull request
Mar 18, 2015
Sort table view columns alphabetically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2638
sortSchemamethod to sort "default" items alphabetically i.e. items that should not be on a specific position according to the predefined priorities