-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kuviz creation integration #717
Conversation
Co-Authored-By: Alberto Romeu <alrocar@users.noreply.github.com>
Co-Authored-By: Alberto Romeu <alrocar@users.noreply.github.com>
Co-Authored-By: Alberto Romeu <alrocar@users.noreply.github.com>
Co-Authored-By: Alberto Romeu <alrocar@users.noreply.github.com>
Co-Authored-By: Alberto Romeu <alrocar@users.noreply.github.com>
Co-Authored-By: Alberto Romeu <alrocar@users.noreply.github.com>
6087cf7
to
e7257cd
Compare
👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just left a few minor comments.
On a high level, this class will largely be hidden from the user, correct? Will it be inside Map().publish()? How do you envision user-facing API for creating, updating, etc.?
Part of the reason for asking this is that I think we should potentially change error messages from Kuviz
-> cartoframes visualizations
or something like that so we're not introducing a term that's more of an implementation detail.
About how Kuviz is used, the following PR resolves the publication: #718 list kuvizs:
update / delete methods:
Kuviz and Visualization are not exactly the same. Kuviz are a subset of visualizations, but with different flows and final results |
Kuviz template
Dataset is immutable
Kuviz publish
Solves a part of #674
The objective is to integrate the new Kuviz class from
carto-python
to use it in publish method of "sharing visualizations" project. In this PR we are only integrating thecreate method
, the rest will be integrated into other PR.The "Kuviz publish" PR will be merged into this one #718 finishing the publication process