Kuviz publish #718
Merged
Kuviz publish #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 31, 2019
houndci-bot
reviewed
Jun 4, 2019
houndci-bot
reviewed
Jun 4, 2019
alrocar
reviewed
Jun 5, 2019
alrocar
reviewed
Jun 5, 2019
alrocar
reviewed
Jun 5, 2019
alrocar
reviewed
Jun 5, 2019
Co-Authored-By: Alberto Romeu <alrocar@users.noreply.github.com>
Co-Authored-By: Alberto Romeu <alrocar@users.noreply.github.com>
Co-Authored-By: Alberto Romeu <alrocar@users.noreply.github.com>
Co-Authored-By: Alberto Romeu <alrocar@users.noreply.github.com>
houndci-bot
reviewed
Jun 5, 2019
houndci-bot
reviewed
Jun 5, 2019
simon-contreras-deel
force-pushed
the
kuviz-publish
branch
from
3aa42ed
to
64b26ba
Compare
andy-esch
reviewed
Jun 5, 2019
andy-esch
suggested changes
Jun 5, 2019
| if not layer.source.dataset.get_is_saved_in_carto(): | ||
| layer.source.dataset.upload(table_name=table_name, context=context) | ||
| layer.source = Source(table_name, context=context) | ||
| warn('Table `{}` created. In order to publish the map, you will need to create a new Regular API ' |
There was a problem hiding this comment.
It'd be pretty sweet if we could help them do that automagically (and explicitly) through cartoframes so that we take away the disruption to the workflow that getting a new key entails.
Related: #542
There was a problem hiding this comment.
We don't have Auth API implemented in carto-python yet, but when we have it, we will be able to do it automagically
andy-esch
reviewed
Jun 5, 2019
| @@ -188,8 +191,33 @@ def __init__(self, | |||
| def _repr_html_(self): | |||
| return self._htmlMap.html | |||
|
|
|||
| def publish(self): | |||
| pass | |||
| def publish(self, name, maps_api_key='default_public', context=None, password=None): | |||
There was a problem hiding this comment.
You can creare a custom visualization wirh password. It is the same as a embed with password
simon-contreras-deel
requested review from
andy-esch and
alrocar
and removed request for
andy-esch
Kuviz template
Dataset is immutable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves a part of #674
Publish method implementation.
Please, you should review #717 first because this one is based on it.