Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0b docs updates #777

Merged
merged 28 commits into from
Jun 18, 2019
Merged

v1.0.0b docs updates #777

merged 28 commits into from
Jun 18, 2019

Conversation

andy-esch
Copy link
Contributor

Ref #756

@andy-esch andy-esch changed the title v1.x docs updates v1.0.0b docs updates Jun 14, 2019
@Jesus89 Jesus89 added this to the Release v1.0b1 milestone Jun 17, 2019
@andy-esch andy-esch marked this pull request as ready for review June 17, 2019 18:17
README.rst Outdated
- Use CARTO's spatially-enabled database for analysis
- Create customizable, interactive CARTO maps in a Jupyter notebook using DataFrames or hosted data
- Augment your data with CARTO's Data Observatory
- Use CARTO for cloud-based analysis
- Try it out without needing a CARTO account by using the `Examples functionality <https://cartoframes.readthedocs.io/en/latest/#module-cartoframes.examples>`__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this URL working?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, changing it

README.rst Outdated

If you do not have an API key, you can use the `Example Context <https://cartoframes.readthedocs.io/en/latest/#module-cartoframes.examples>`__ to read the example data, make maps, and run arbitrary queries from the datasets there. The best place to get started is in the "Example Datasets" notebook found when running binder or downloading from the `examples <https://github.com/CartoDB/cartoframes/blob/master/examples/Example%20Datasets.ipynb>`__ directory in the cartoframes GitHub repository.
If you do not have an API key, you can still use cartoframes for creating maps locally.

.. note::
The example context only provides read access, so not all cartoframes features are available. For full access, `Start a free 30 day trial <https://carto.com/signup>`__ or get free access with a `GitHub Student Developer Pack <https://education.github.com/pack>`__.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14 day trial now, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted


.. image:: https://raw.githubusercontent.com/CartoDB/cartoframes/master/docs/img/read_demo.gif
.. image:: https://raw.githubusercontent.com/CartoDB/cartoframes/master/docs/img/data-workflow.gif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add GIF to the repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's added, but this link won't work until this is all merged into master. I think this isn't the best way to point to images, but I'll see if I can find a better way. The problem is that the README needs to work both in the github repo and the readthedocs site.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.rst Outdated

.. image:: https://raw.githubusercontent.com/CartoDB/cartoframes/master/docs/img/read_demo.gif
.. image:: https://raw.githubusercontent.com/CartoDB/cartoframes/master/docs/img/data-workflow.gif

Write an existing pandas DataFrame to CARTO.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cc.write example is covered with the previous one (d.upload), right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct! Removing :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also made me look at the upload example and realize I made some mistakes

try out that code, install `cartoframes` as:

`pip install git+https://github.com/cartodb/cartoframes.git@add-legends-v1#egg=cartoframes`

Data Observatory
----------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move the Credentials class to cartoframes.auth so we can update the section CARTO Credential Management

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I don't mind doing that in this PR but seems like it might be a good idea to do in another one. Just created an issue: #795

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True

}

Map(
Layer('table in your account'),
basemap
)

Color basemap style.
Remove basemap and show a custom color.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the basemaps import from Mapbox and custom basemap examples.

)

basemap = {
'style': 'mapbox://styles/mapbox/streets-v9',
'token: '<your mapbox token>'
'token: 'your Mapbox token'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'token' <

(single quote)


.. code::

from cartoframes.viz import Map, Layer, basemaps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basemaps not required here

@andy-esch
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants