Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validate item name helper + add tests #143

Merged
merged 7 commits into from
Jul 4, 2020

Conversation

niekcandaele
Copy link
Member

fixes #65

@niekcandaele niekcandaele requested a review from halkeye July 4, 2020 13:28
niekcandaele and others added 2 commits July 4, 2020 22:52
Co-authored-by: Gavin Mogan <git@gavinmogan.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6f49ad8). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #143   +/-   ##
=========================================
  Coverage          ?   20.93%           
=========================================
  Files             ?      394           
  Lines             ?     6273           
  Branches          ?        0           
=========================================
  Hits              ?     1313           
  Misses            ?     4960           
  Partials          ?        0           
Impacted Files Coverage Δ
api/helpers/sdtd/validate-item-name.js 100.00% <100.00%> (ø)
...controllers/SdtdServer/commands/enable-commands.js 25.00% <0.00%> (ø)
api/controllers/SdtdServer/view-gbl.js 12.50% <0.00%> (ø)
api/controllers/BannedItemList/set-command.js 33.33% <0.00%> (ø)
...i/controllers/SdtdServer/economy/enable-economy.js 14.28% <0.00%> (ø)
...ollers/SdtdServer/commands/get-player-teleports.js 33.33% <0.00%> (ø)
api/helpers/load-sdtdServer-info.js 9.52% <0.00%> (ø)
api/controllers/SdtdServer/restart-server.js 8.33% <0.00%> (ø)
api/helpers/meta/load-system-stats-and-info.js 7.69% <0.00%> (ø)
...lers/SdtdServer/countryBan/get-banned-countries.js 33.33% <0.00%> (ø)
... and 385 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f49ad8...7fc2f05. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Jul 4, 2020

Code Climate has analyzed commit 7fc2f05 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.9% (0.1% change).

View more on Code Climate.

@niekcandaele niekcandaele merged commit ec4b5d5 into master Jul 4, 2020
@niekcandaele niekcandaele deleted the niekcandaele/issue65 branch July 4, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor validate item helper
3 participants