This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Use a config param for private src repo access token #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarath-p
reviewed
Oct 24, 2019
sarath-p
approved these changes
Oct 24, 2019
edaena
approved these changes
Oct 25, 2019
spk-config.yaml
Outdated
| @@ -23,6 +23,7 @@ introspection: | |||
| table_name: "storage-account-table-name" # Must be defined to run spk deployment commands | |||
| partition_key: "storage-account-table-partition-key" # Must be defined to run spk deployment commands | |||
| key: "storage-access-key" # Must be defined to run spk deployment commands. Use ${env:INTROSPECTION_STORAGE_ACCESS_KEY} and set it in .env file | |||
| source_repo_access_token: "source_repo_access_token" # Optional. Define this to see author names in the dashboard | |||
There was a problem hiding this comment.
Can you add in the comment that this is only required for private repos, and/or the other conditions under which this parameter is required?
There was a problem hiding this comment.
Just addressed this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes microsoft/bedrock#707
When the source repo is private, spektate needs a personal access token to get Author information.
Corresponding PR in spektate: microsoft/spektate#42