This repository was archived by the owner on Apr 13, 2020. It is now read-only.
[FIX] Attempt to fix issue 935: Intermittent SPK unit test failure related to SPK infra #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses microsoft/bedrock#935. |
yradsmikham
approved these changes
Feb 3, 2020
andrebriggs
approved these changes
Feb 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot reproduce this problem on own laptop and we are making some guesses. The failing test is calling
generate.validateRemoteSourcefunction is an async one. In this function, there are a handful of git related async function calls. We suspect that timeout is due to the tardiness in these functions. One way to address problem is to breakgenerate.validateRemoteSourceinto small functions that's havinggenerate.validateRemoteSourceto call other function ingenerate.ts. In this manner, we have mocked these small (size) functions in the failing test. And then having additional unit tests to test these small functions individually.Closes microsoft/bedrock#935