This repository was archived by the owner on Apr 13, 2020. It is now read-only.
fix eslint warnings/errors in Deployment Dashboard command #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisseah
requested review from
samiyaakhtar,
evanlouie,
edaena,
andrebriggs and
mtarng
evanlouie
approved these changes
Mar 25, 2020
2 tasks
|
@samiyaakhtar I believe microsoft/bedrock#1244 is targeting at spektate repo and this PR is on spk repo. Thanks |
samiyaakhtar
approved these changes
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to microsoft/bedrock#1157
after switching to eslint, we have disabled some rules. This is to remove eslint-disable in deployment dashboard command by using an interface to gather all the values needed for the command. e.g. avoid using non null assertion operations like this
config.introspection!.azure!.source_repo_access_token