Crash in LetterBitmap.pickColor

[TheLastProject]

Just reported with our brand new crash reporter. Thanks ACRA, didn't expect you to come in handy this quickly.

OnePlus 13 (CPH2653), Android 15.

User reported the crash happening the moment they tapped the search button.

STACK_TRACE=java.lang.UnsupportedOperationException: Can't convert value at index 7 to color: type=0x1, theme=null
	at android.content.res.TypedArray.getColor(TypedArray.java:539)
	at protect.card_locker.LetterBitmap.pickColor(LetterBitmap.java:125)
	at protect.card_locker.LetterBitmap.getDefaultColor(LetterBitmap.java:140)
	at protect.card_locker.Utils.getHeaderColor(Utils.java:1132)
	at protect.card_locker.Utils.setIconOrTextWithBackground(Utils.java:1090)
	at protect.card_locker.LoyaltyCardCursorAdapter.onBindViewHolder(LoyaltyCardCursorAdapter.java:127)
	at protect.card_locker.LoyaltyCardCursorAdapter.onBindViewHolder(LoyaltyCardCursorAdapter.java:35)
	at protect.card_locker.BaseCursorAdapter.onBindViewHolder(BaseCursorAdapter.java:34)
	at androidx.recyclerview.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:7254)
	at androidx.recyclerview.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:7337)
	at androidx.recyclerview.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:6194)
	at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6460)
	at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6300)
	at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6296)
	at androidx.recyclerview.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2330)
	at androidx.recyclerview.widget.GridLayoutManager.layoutChunk(GridLayoutManager.java:572)
	at androidx.recyclerview.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1591)
	at androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:668)
	at androidx.recyclerview.widget.GridLayoutManager.onLayoutChildren(GridLayoutManager.java:170)
	at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:4309)
	at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4012)
	at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4578)
	at android.view.View.layout(View.java:25941)
	at android.view.ViewGroup.layout(ViewGroup.java:6618)
	at android.widget.RelativeLayout.onLayout(RelativeLayout.java:1103)
	at android.view.View.layout(View.java:25941)
	at android.view.ViewGroup.layout(ViewGroup.java:6618)
	at com.google.android.material.appbar.HeaderScrollingViewBehavior.layoutChild(HeaderScrollingViewBehavior.java:145)
	at com.google.android.material.appbar.ViewOffsetBehavior.onLayoutChild(ViewOffsetBehavior.java:43)
	at com.google.android.material.appbar.AppBarLayout$ScrollingViewBehavior.onLayoutChild(AppBarLayout.java:2461)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:918)
	at android.view.View.layout(View.java:25941)
	at android.view.ViewGroup.layout(ViewGroup.java:6618)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:25941)
	at android.view.ViewGroup.layout(ViewGroup.java:6618)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:25941)
	at android.view.ViewGroup.layout(ViewGroup.java:6618)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:25941)
	at android.view.ViewGroup.layout(ViewGroup.java:6618)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1906)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1729)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1638)
	at android.view.View.layout(View.java:25941)
	at android.view.ViewGroup.layout(ViewGroup.java:6618)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at com.android.internal.policy.DecorView.onLayout(DecorView.java:861)
	at android.view.View.layout(View.java:25941)
	at android.view.ViewGroup.layout(ViewGroup.java:6618)
	at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:5563)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:4621)
	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:3356)
	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:11602)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1656)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1665)
	at android.view.Choreographer.doCallbacks(Choreographer.java:1183)
	at android.view.Choreographer.doFrame(Choreographer.java:1066)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1639)
	at android.os.Handler.handleCallback(Handler.java:995)
	at android.os.Handler.dispatchMessage(Handler.java:105)
	at android.os.Looper.loopOnce(Looper.java:288)
	at android.os.Looper.loop(Looper.java:393)
	at android.app.ActivityThread.main(ActivityThread.java:9564)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:600)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1010)

[TheLastProject]

I think I might have found it:

In
https://github.com/CatimaLoyalty/Android/blob/main/app/src/main/java/protect/card_locker/LetterBitmap.java#L136-L143
it uses obtainTypedArray to get letter_tile_colors in

Android/app/src/main/res/values/settings.xml

Lines 164 to 172 in fa15251

	<array name="letter_tile_colors">
	<item>#f16364</item>
	<item>#f58559</item>
	<item>#f9a43e</item>
	<item>#67bf74</item>
	<item>#59a2be</item>
	<item>#2093cd</item>
	<item>#ad62a7</item>
	</array>

which is 7 items long, but in

Android/app/src/main/java/protect/card_locker/LetterBitmap.java

Lines 116 to 126 in fa15251

	/**
	* @param key The key used to generate the tile color
	* @return A new or previously chosen color for <code>key</code> used as the
	* tile background color
	*/
	private static int pickColor(String key, TypedArray colors) {
	// String.hashCode() is not supposed to change across java versions, so
	// this should guarantee the same key always maps to the same color
	final int color = Math.abs(key.hashCode()) % NUM_OF_TILE_COLORS;
	return colors.getColor(color, Color.BLACK);
	}

it assumes the list is 8 items long.

This bug has been around since 8 years then it seems! But it's only really showing up now. It seems to be based on the store name, the user probably has one card with a store name that happens to pick a really poor default colour.

Would be good to know the user's store names to see if I can confirm my suspicion :)