Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#165546870 feedbacks fixes #92

Merged
merged 1 commit into from
Apr 25, 2019
Merged

#165546870 feedbacks fixes #92

merged 1 commit into from
Apr 25, 2019

Conversation

Cavdy
Copy link
Owner

@Cavdy Cavdy commented Apr 25, 2019

What does this PR do?

Feedback fixes

Description of Task to be completed?

  • Separate migration from the database

  • Write more test cases

  • Write comments with jsdocs,

  • Make login and signup form in one,

  • Added more eslint configurations

  • Fix auth to have prefix v1

  • Fix eslint disable

  • Fix codeclimate badge

  • Fix on delete error response

  • Make initial account draft on creation

  • Fix whitespace on the signup form

How should this be manually tested?

N/A

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#165546870

Screenshots (if appropriate)

N/A

Questions:

N/A

Feedback fixes
Seperate migration from database, write more test cases, write comments with jsdocs, make login and signup form in one, added more eslint configurations, fix auth to have prefix v1, fix eslint disable, fix codeclimate badge, fix on delete error, make initial account draft on creation, fix whitespace on signup form
[Starts #165546870]
@Cavdy Cavdy merged commit c37e467 into frontend-app Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant