Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop comma that causes install to fail #98

Merged
merged 7 commits into from
Aug 21, 2020
Merged

Conversation

nicholsn
Copy link
Contributor

This PR simply drops a comma in setup.py that was causing an installation issue on ubuntu 18.04 with both pip install centrosome and python setup.py install.

pip 20.0.2 from /usr/local/lib/python2.7/dist-packages/pip (python 2.7)
Python 2.7.17

Here is the error that is fixed:

Collecting centrosome
  Using cached centrosome-1.1.7.tar.gz (543 kB)
    ERROR: Command errored out with exit status 1:
     command: /usr/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-muJE3W/centrosome/setup.py'"'"'; __file__='"'"'/tmp/pip-install-muJE3W/centrosome/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-muJE3W/centrosome/pip-egg-info
         cwd: /tmp/pip-install-muJE3W/centrosome/
    Complete output (6 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-muJE3W/centrosome/setup.py", line 84
        **__extkwargs,
                     ^
    SyntaxError: invalid syntax
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.```

@jburel jburel mentioned this pull request Apr 27, 2020
@jburel
Copy link
Contributor

jburel commented Apr 27, 2020

@nicholsn
I just noticed your PR after fixing the same issue
you may want to cherry-pick 80375d2
since that extra comma fails travis

@nicholsn
Copy link
Contributor Author

@jburel what branch is that commit on? (also I could just close this since you already fixed it)

git cherry-pick 80375d2
fatal: bad revision '80375d2'

@jburel
Copy link
Contributor

jburel commented Apr 27, 2020

Sorry for the confusion it was on my repository, you will need to keep your PR opened
This is the change I indicated
jburel@80375d2
so you could do something similar in this PR

@jburel
Copy link
Contributor

jburel commented Apr 28, 2020

@nicholsn I have opened a new PR against your branch
it removes few more extra commas and it fixes the travis build everything should be green now
see https://travis-ci.org/github/jburel/centrosome/builds/680434025

@nicholsn
Copy link
Contributor Author

@jburel great thanks, merged and now this is passing!

@jburel
Copy link
Contributor

jburel commented Apr 29, 2020

Any chance to get that PR merge @0x00b1 and have a new release of centrosome?
version 1.1.7 is currently broken without the changes in this PR.

@jburel
Copy link
Contributor

jburel commented Jul 17, 2020

@0x00b1 @bethac07 Any chance to get that PR merged and have a new release of this package?

@0x00b1
Copy link
Contributor

0x00b1 commented Aug 21, 2020

Yep! Thanks everyone! Merging now, will package and release today.

@0x00b1 0x00b1 merged commit a57a5b4 into CellProfiler:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants