[ENG-8779] api response in browser #885
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaxelb
force-pushed
the
feat/8779-api-response-in-browser
branch
2 times, most recently
from
d5484cf to
b1f2263
Compare
- replace `trove.render._rendering` module with `trove.render.rendering` package (separate file for each rendering class) - make `ProtoRendering` an actual `typing.Protocol` and narrow types to only unicode `str` - add `trove.render.rendering.html_wrapped.HtmlWrappedRendering` that puts minimal `<!DOCTYPE html><pre>...</pre>` around an inner rendering - use `HtmlWrappedRendering` to wrap responses that aren't html or json, when `Accept` header allows html and query params omit `withFileName` - use mediatype constants more consistently (leaving off charset except for content-type header)
aaxelb
force-pushed
the
feat/8779-api-response-in-browser
branch
3 times, most recently
from
fb7ed0a to
abc9985
Compare
aaxelb
force-pushed
the
feat/8779-api-response-in-browser
branch
from
abc9985 to
f6f285a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main point is to improve in-browser experience of the api
Acceptheader accepts html, give non-html responses (requested withacceptMediatypequery param) wrapped in a minimal html<pre>acceptMediatypequery param doesn't specify (don't worry too much about the details)while True:antipattern (honestly irrelevant to the rest)ENG-8779