Feature/Pull Upstream Nested Dataverses Fix [PLAT-1328] #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stringify content-length header to fix requests
…rses. - Dataverse dicts don't have protocol key.
…n on the Dataset.id property if a dataverse is hit before a dataset.
…tocol_key_error Feature/Nested Dataverse Protocol Key Error
pattisdr
changed the title
|
@felliott, do you know who has perms to merge this? |
|
"Not I", said the @felliott. |
|
@mfraezz, can you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Gets our fork up-to-date with IQSS/dataverse-client-python:master
Changes
Upstream, IQSS#51 was merged which has the fix for the KeyError that was sometimes thrown when someone attempted to connect a dataset, but they also had a nested dataverses inside of their dataverse that was hit before the desired dataset was located.
When this is merged, we can point osf.io towards the appropriate commit CenterForOpenScience/osf.io#8939
Ticket
https://openscience.atlassian.net/browse/PLAT-1328