Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-2227] Load all authors for moderator preprint detail page #177

Merged

Conversation

futa-ikeda
Copy link
Contributor

Purpose

  • Allow more than 10 preprint authors to be shown to moderators on the preprint detail page

Summary of Changes/Side Effects

  • Explicitly fetch all contributors for a given preprint, instead of just the first 10 using loadAll

Screenshot

Screenshot of contributor list on routes like osf.io/reviews/preprints/<provider_id>/<preprint_id>
Screen Shot 2021-04-08 at 11 03 17 AM

Testing Notes

  • This fix pertains to the reviews app, so make sure sure you are looking at the preprint detail page as a moderator, and not as a preprint author!
  • Please ensure that a moderator for a preprint provider can see all the contributors on a preprint if there are more than 10 contributors (Note: depending on the server's speed, it may show the first 10 initially, then quietly be loading the next 10, and so on)
  • For preprints with less than 10 contributors, the behavior should be unchanged

Ticket

https://openscience.atlassian.net/browse/ENG-2227

Notes for Reviewer

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

@coveralls
Copy link

coveralls commented Apr 8, 2021

Coverage Status

Coverage decreased (-0.1%) to 52.137% when pulling 7222a62 on futa-ikeda:feature/load-all-contribs into 442605d on CenterForOpenScience:develop.

Copy link
Member

@fabmiz fabmiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@adlius adlius merged commit 588b9d3 into CenterForOpenScience:develop Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants