Skip to content

Conversation

bp-cos
Copy link
Contributor

@bp-cos bp-cos commented Apr 5, 2024

Purpose

Added the public preregistration to the author assertions page

Summary of Changes

Add a new public preregistration component

Screenshot(s)

Screenshot 2024-04-05 at 10 08 52 AM

Screenshot 2024-04-05 at 10 09 02 AM

Screenshot 2024-04-05 at 10 09 11 AM

Screenshot 2024-04-11 at 1 33 10 PM

Side Effects

None

QA Notes

None

@bp-cos bp-cos requested review from cslzchen and futa-ikeda April 5, 2024 16:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8572628743

Details

  • 14 of 288 (4.86%) changed or added relevant lines in 23 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.3%) to 65.858%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/preprints/-components/submit/review/component.ts 0 1 0.0%
app/preprints/-components/submit/supplements/component.ts 0 1 0.0%
app/preprints/submit/controller.ts 0 1 0.0%
app/adapters/contributor.ts 5 7 71.43%
app/preprints/select/route.ts 0 2 0.0%
app/preprints/-components/preprint-provider-display/component.ts 0 3 0.0%
app/preprints/-components/submit/preprint-state-machine/action-flow/component.ts 0 3 0.0%
app/preprints/-components/submit/component.ts 0 6 0.0%
app/preprints/-components/submit/title-and-file/component.ts 1 8 12.5%
app/preprints/-components/submit/author-assertions/data-link-widget/data-link/component.ts 1 9 11.11%
Totals Coverage Status
Change from base Build 8526439968: -2.3%
Covered Lines: 6156
Relevant Lines: 9045

💛 - Coveralls

@brianjgeiger brianjgeiger changed the base branch from develop to feature/preprints-phase-2 April 11, 2024 17:48
@bp-cos bp-cos force-pushed the feature/eng-5346 branch from 8cf5772 to 23aa522 Compare April 11, 2024 19:32
@bp-cos bp-cos changed the title [DRAFT] [ENG-5346] Added the public preregistration to the author assertions page [ENG-5346] Added the public preregistration to the author assertions page Apr 11, 2024
Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good over all. Just some minor changes

Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🔥

@bp-cos bp-cos merged commit 10d108e into CenterForOpenScience:feature/preprints-phase-2 Apr 12, 2024
@bp-cos bp-cos deleted the feature/eng-5346 branch April 12, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants