[ENG-5900] Added the ability to make the assertion page read-only for non-admins #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futa-ikeda
approved these changes
Aug 19, 2024
Comment on lines
23
to
+24
| <div local-class='delete-container'> | ||
| <Button | ||
| data-test-remove-link | ||
| aria-label={{t 'preprints.submit.step-assertions.public-link-remove-button'}} | ||
| @layout='fake-link' | ||
| {{on 'click' this.removeLink}} | ||
| > | ||
| <FaIcon @icon='times' local-class='delete' /> | ||
| <EmberTooltip> | ||
| {{t 'preprints.submit.step-assertions.public-link-remove-button'}} | ||
| </EmberTooltip> | ||
| </Button> | ||
| {{#unless @disabled}} |
There was a problem hiding this comment.
Super minor nit, could add this {{#unless}} outside of the <div> here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
ENG-5900 Added the ability to make the assertion page read-only for non-admins
Summary of Changes
Passed an 'isElementDisabled' or 'isAdmin' attribute around to the components on the assertion page.
Screenshot(s)
Side Effects
Likely many
QA Notes
Test it