Skip to content

[ENG-7472] fixed recent preprint rejected versions doesnt have option to resubmit #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2025
Merged

[ENG-7472] fixed recent preprint rejected versions doesnt have option to resubmit #2528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e60486
fixed recent preprint rejected versions doesnt have option to resubmit
bodintsov Mar 18, 2025
89b24d3
update tests
bodintsov Mar 18, 2025
1416950
update test message
bodintsov Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/preprints/detail/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ export default class PrePrintsDetailController extends Controller {
get showEditButton() {
const providerIsPremod = this.model.provider.reviewsWorkflow === PreprintProviderReviewsWorkFlow.PRE_MODERATION;
const preprintIsRejected = this.model.preprint.reviewsState === ReviewsState.REJECTED;
const preprintIsFirstVersion = this.model.preprint.version === 1;

if (!this.userIsContrib) {
return false;
Expand All @@ -105,8 +104,7 @@ export default class PrePrintsDetailController extends Controller {
return true;
}
// Edit and resubmit
if (preprintIsFirstVersion && preprintIsRejected
&& this.model.preprint.currentUserIsAdmin) {
if (preprintIsRejected && this.model.preprint.currentUserIsAdmin) {
return true;
}
}
Expand Down
15 changes: 13 additions & 2 deletions tests/acceptance/preprints/detail-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ module('Acceptance | preprints | detail', hooks => {
assert.dom('[data-test-edit-preprint-button]')
.doesNotExist('Edit button is not displayed for non-latest versions');

// Not initial, pre-mod, rejected
// Not initial, pre-mod, rejected, not latest
preprint.setProperties({
reviewsState: ReviewsState.REJECTED,
version: 4,
Expand All @@ -208,7 +208,18 @@ module('Acceptance | preprints | detail', hooks => {
});
await settled();
assert.dom('[data-test-edit-preprint-button]')
.doesNotExist('Edit button is not displayed for non-initial pre-mod rejected');
.exists('Edit button is displayed for non-initial pre-mod not latest rejected');

// Not initial, pre-mod, rejected, latest
preprint.setProperties({
reviewsState: ReviewsState.REJECTED,
version: 4,
isLatestVersion: true,
currentUserPermissions: Object.values(Permission),
});
await settled();
assert.dom('[data-test-edit-preprint-button]')
.exists('Edit button is displayed for non-initial pre-mod latest rejected');

// Initial, pre-mod, rejected
preprint.setProperties({
Expand Down