-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] ORCID login [#OSF-5162, 6881, 6885] #6192
Merged
Merged
Changes from 13 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
aa34e8f
ORCID Login: update `User` model.
cslzchen 4985794
Add support for OSF to handle cas service ticket from oauth login.
cslzchen aa7f563
Add `oauth_user_email_[get|post]` for first-time oauth-login users to…
cslzchen cecc0bd
Update `User.oauth`, `User.create_unconfirmed()` and `get_user()`.
cslzchen ee563c4
Update `oauth_user_email_[get|post]`:
cslzchen 5bc7939
Implement account creation for new user login thorugh oauth. [skip ci]
cslzchen 609fcac
Refactor `oauth` to `external_identiy`:
cslzchen e09480f
Refactor `User.external_identity` to include `status`:
cslzchen ce1a2c8
Update auth logic with new `User.external_identity.status`:
cslzchen 296fcef
Partially implement account linking for external login. [skip ci]
cslzchen 3e7ddde
Fully implement account linking logic for external login and update a…
cslzchen 99aa7c9
Merge remote-tracking branch 'cos/pr/6177' into HEAD
mfraezz 0c44ee0
Add external_identity to default keys in test
mfraezz 76c21d7
Fix method name
mfraezz 65bdf8c
Normalize key
mfraezz fb16f2e
Add auth tests
mfraezz 15d22de
Add model tests
mfraezz fd8a93b
Use service-specific verification email templates
mfraezz 88e59cc
Add tests for external_login_confirm_email
mfraezz 150575c
Add template for link success
mfraezz 63e45da
Update `external_first_login_authenticate()` to match CAS service res…
cslzchen 2e03a84
Add valid external identity providers list and map profile name to pr…
cslzchen 853ac3a
Update `make_response_from_ticket()` for new CAS service response:
cslzchen 550a9ef
Merge remote-tracking branch 'upstream/feature/orcid-login' into feat…
cslzchen 5fd21e6
Several minor updates:
cslzchen e2a4add
Support user merging for external_identities
mfraezz fbdbc1c
Merge remote-tracking branch 'cos/pr/6198' into feature/orcid-tests
mfraezz 2412c25
Remove unnecessary kwarg
mfraezz 396ea4b
Update tests
mfraezz d17eefd
Update forgotten test
mfraezz 69a9e30
Add test for `external_login_email_get()`.
cslzchen 85ef767
Several minor updates:
cslzchen 3a71b0d
Add test for `external_login_email_get()`.
cslzchen 8debe14
Merge remote-tracking branch 'upstream/feature/orcid-login' into feat…
cslzchen cfbbf33
Fix old `User.external_identity` model to support for merging externa…
cslzchen 94f6b71
User can add more than one external id (fix the overwrite issue).
cslzchen 3fa7b15
Fix key error in `User.external_identity`.
cslzchen fe6b1f8
Merge remote-tracking branch 'cos/pr/6200' into HEAD
mfraezz a0a88dd
Remove duplicate save call
mfraezz 7d845e0
Fix external_identity preservation during merge
mfraezz 0aa08eb
Add merge test for external_identity
mfraezz 967d4c6
external account cancel option to avoid login loop
icereval 86724d3
Prevent possible KeyError if fields omitted
mfraezz 5ac4c83
[Feature] Add support for revoking ORCID login (#6212)
mfraezz 19e7300
Send PATCH instead of DELETE
mfraezz 94ba9b4
Add social linking language to email
mfraezz 7f0f43f
Improve security of external identities
mfraezz b0f9129
Ensure unreg users are registered on confirm
mfraezz 442cf3c
Add defaults for cas_response names
mfraezz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs to be updated.