Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[djangosf] Figshare Addon #6671

Merged
merged 3 commits into from
Dec 16, 2016
Merged

[djangosf] Figshare Addon #6671

merged 3 commits into from
Dec 16, 2016

Conversation

mfraezz
Copy link
Member

@mfraezz mfraezz commented Dec 15, 2016 •
edited
Loading

Purpose

Add Figshare addon to DjangOSF

Changes

  • Migrate models/settings/tests
  • Reorganize TCI jobs, add addons/ to modules tested.

Side effects

  1. 14 more tests are failing because an extra thousand are now being ran.
  2. More jobs are failing (3/5 instead of 1/5) due to test redistribution.
  3. No tests are failing due to 429's, but this is not a long-term solution to that issue.

Ticket

None known.

@mfraezz mfraezz force-pushed the feature/djosf-figshare branch from f980cf5 to 6089c45 Compare December 16, 2016 03:50
@mfraezz mfraezz force-pushed the feature/djosf-figshare branch from 6089c45 to 6563321 Compare December 16, 2016 18:09
@sloria
Copy link
Contributor

sloria commented Dec 16, 2016

👍

@mfraezz mfraezz merged commit d7d20b2 into CenterForOpenScience:feature/django-osf Dec 16, 2016
@mfraezz mfraezz deleted the feature/djosf-figshare branch December 16, 2016 19:33
cwisecarver
cwisecarver reviewed Dec 16, 2016
View reviewed changes
Copy link
Contributor

@cwisecarver cwisecarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwisecarver cwisecarver cwisecarver left review comments

@sloria sloria Awaiting requested review from sloria

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfraezz @sloria @cwisecarver