Update triangulation algorithm #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
force-pushed
the
fix-triangulation
branch
from
631d188
to
1426d0e
Compare
|
@hpinkos could you check this out? The new code starts here: https://github.com/AnalyticalGraphicsInc/obj2gltf/pull/157/files#diff-608b0b654865416bb99fb5d336cf3307R297 |
|
I don't have write access to this repo so I can't merge it, but this looks good to me @lilleyse |
|
Thanks @hpinkos. I'm going to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147 by updating to the latest triangulation code used in Cesium. This fixes a model that wasn't triangulating correctly in
master. This fix required updating Cesium so I updated other dependencies with it.csxirc5h.i2b.obj
Before and after:
There are still some back facing polygons but I confirmed they are present in the original model too. We don't yet do that sort of correction.
(Backfacing polygons on the steps)
I checked that the new method still triangulates these models correctly:
#33
#50
#79
One thing I'm not completely sure about is whether
PolygonPipeline.computeWindingOrder2Dis enough to check the winding order. Would it need to use the normal like the 3-sided case?