ci(circleci): move forward to CircleCI #49

clearloop · 2021-04-27T05:41:37Z

Changes

Use CircleCI instead of Github actions

remove Github action test-code.yml
remove Github action docker.yml

Both of the above are squashed into the .circleci/config.yml now

Tests

~~Here is a testing CI on my fork clearloop/PINT~~

cached	time spent
false	~20 mins
true	~10 mins

Issues

~~This PR moved the docker CI to CircleCI as well~~

It could be faster if we caching target/**/*, but it's not elegant
The clippy-check action of Github Actions is awesome but we'll lose it as we migrating to CircleCI

Closes #47

.circleci/config.yml

clearloop · 2021-04-27T11:53:36Z

.circleci/config.yml

+      - restore_cargo_package_cache
+      - run:
+          name: Run Tests
+          command: cargo test --all


clearloop · 2021-04-27T11:53:52Z

.circleci/config.yml

+      - restore_cargo_package_cache
+      - run:
+          name: clippy check
+          command: cargo clippy --all-targets


* ci(cache): download sccahce binary directly * ci(cach): sudo privilege to moving sccache binary * ci(cache): use x86_64 sccache for the testing machine * ci(cache): correct the url of sccache resource * ci(sccache): clean the indent * ci(security): requires reust_setup only * ci(cache): use optional feature to run rust_setup conditionally * ci(rust_setup): fix installing sccache * ci(rust_setup): clean rust_setup * ci(workflow): requires prefetch-cache * ci(format): add rust_setup to format job * ci(cache): add sccache to rust_setup * ci(curl): fix the test script about downloading from links * ci(condition): use if-else * ci(prefetch): remove prefetch-crates * ci(security): force installing rust-toolchain in job security * ci(cache): use cache for security checking * ci(security): remove os deps in security check * ci(chore): uppercase job names

clearloop · 2021-04-28T09:45:20Z

Finished, @mattsse , it could be faster if we cache path/to/target, but comparing with using sccache, it's not elegant indeed.

mattsse

LGTM! however I've configured Circleci only a couple of time so I may have missed something.

mattsse · 2021-04-28T11:03:32Z

.circleci/config.yml

+            - docker-publish-latest
+          filters:
+            tags:
+              only: /^v.*/


What is this tag for?

This will trigger publishing chainsafe/pint:x.x.x images everytime we tagging PINT with vx.x.x in github

mattsse · 2021-04-28T11:07:25Z

.circleci/config.yml

+      IMAGE_NAME: chainsafe/pint
+      CARGO_AUDIT: /home/circleci/.cargo/bin/cargo-audit
+      RUSTC_WRAPPER: /home/circleci/.cargo/bin/sccache
+      RUSTC_TOOLCHAIN: nightly-2021-04-18


What's best practice for selecting nightly toolchain. lastest can be incomplete sometimes, right? Is there any downside of setting this randomly to a recent date like we do here?

Using $ curl --proto '=https' --tlsv1.2 https://sh.rustup.rs -sSf | sh follows installation with specified nightly channel will download the lastest nightly rust.

But I think using a specified version of rust can help us reduce the time modifying CI, substrate updates really fast, and sometimes the latest toolchains have bugs for compiling substrate.

For example, there was a big change in the rust compiler after 2020-10-05, substrate could not be compiled with the latest toolchains for months, and rust toolchains after 2020-03-13, have bugs compiling the debug info in wasm32-unknown-unknown target

clearloop added 20 commits April 27, 2021 13:39

ci(circleci): init the config of circleci

b6ae0c4

fix(vectors): remove test-vectors

8bfc561

ci(daily-check): remove daily check

37b1ce9

ci(jobs): clean jobs

4a78ecb

ci(rust_setup): install rust toolchain without prompt

39c1a65

ci(format): optimize format step

bb9258d

ci(compile): verbose output

1b89daa

ci(timeout): set no_output_timeout

5e5975f

ci(circleci): remove verbose output in circle ci

e27475e

ci(docker): setup docker jobs

04a4026

Merge branch 'main' into cl/circle-ci

389b64b

ci(docker): remove docker ci in github actions

4c82790

ci(docker): add executor to docker jobs

cd1d214

ci(docker): fix typo in job names

f75f383

ci(docker): setup docker executor

5207ecd

ci(docker): fix docker-build target directory

387d903

ci(docker): persist docker image

1c074c6

ci(docker): stringify dockerb build arguments

7f0dbf2

ci(docker): fix the fucking format of the circleci config

abbb8e3

ci(docker): checkout before building image

42c88ae

clearloop commented Apr 27, 2021

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

clearloop commented Apr 27, 2021

View reviewed changes

.circleci/config.yml

- restore_cargo_package_cache

- run:

name: Run Tests

command: cargo test --all

Copy link

Contributor Author

clearloop Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#46

clearloop commented Apr 27, 2021

View reviewed changes

.circleci/config.yml

- restore_cargo_package_cache

- run:

name: clippy check

command: cargo clippy --all-targets

Copy link

Contributor Author

clearloop Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#46

clearloop added 7 commits April 27, 2021 21:18

ci(docker): set no_output_timeout

73c074d

ci(machine): use ubuntu-2004

d960300

ci(docker): use xlarge resource for docker builder

60d26f8

ci(docker): remove docker executor

953da73

ci(executor): fix the indent of machine config

7fbfb9c

ci(executor): move environment out of machine config

66820bf

ci(docker): add docker syntax

112df56

clearloop added 5 commits April 28, 2021 01:18

ci(cache): use sccache cache

04725bf

ci(cache): unset rustc wrapper for installing sccache

cbe2b53

ci(cache): fetch sccache before fetching packages

20b81eb

ci(cache): cache sccache binary

97e5a26

ci(docker): make login dockerhub as a command

6425778

clearloop removed the needs review PR needs reviewing label Apr 27, 2021

clearloop and others added 13 commits April 28, 2021 01:54

ci(docker): fix type of command login_dockerhub

cccabd7

ci(cache): cache sccache and cargo-audit binaries ( under 20MB )

0332c49

ci(cache): fix the cache of cargo binaries

f889518

ci(cache): squash the cahce of cargo-audit and sccache binaries

c391257

ci(cache): fix the typo of the condition of cargo-audit

8d581bb

ci(cache): fix the cache condition of sccache

a025da0

ci(cache): modify sccache-cache storage key to trigger CI

59ef526

ci(cache): fix cache paths

1af0d66

ci(machine): use xlarge resource

a0f03d0

ci(trigger): trigger build and test cache

750a5c7

ci(cache): embed restore_cache into rust_setup

037fcf8

ci(chore): trigger building

c5dacfe

clearloop added the needs review PR needs reviewing label Apr 28, 2021

clearloop changed the title ~~Move forward to CircleCI~~ ci(circleci): move forward to CircleCI Apr 28, 2021

mattsse approved these changes Apr 28, 2021

View reviewed changes

mattsse added approved PR approved to merge and removed needs review PR needs reviewing labels Apr 28, 2021

clearloop merged commit c861835 into main Apr 28, 2021

clearloop deleted the cl/circle-ci branch April 28, 2021 12:23

This was referenced Apr 28, 2021

ci(docker): hotfix the trigger of publishing docker images by tags #61

Merged

Display clippy check comments on PRs #62

Closed

Display clippy check comments on PR files ChainSafe/forest#1088

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(circleci): move forward to CircleCI #49

ci(circleci): move forward to CircleCI #49

clearloop commented Apr 27, 2021 •

edited

Loading

clearloop Apr 27, 2021

clearloop Apr 27, 2021

clearloop commented Apr 28, 2021

mattsse left a comment

mattsse Apr 28, 2021

clearloop Apr 28, 2021 •

edited

Loading

mattsse Apr 28, 2021

clearloop Apr 28, 2021 •

edited

Loading

ci(circleci): move forward to CircleCI #49

ci(circleci): move forward to CircleCI #49

Conversation

clearloop commented Apr 27, 2021 • edited Loading

Changes

Tests

Issues

clearloop Apr 27, 2021

Choose a reason for hiding this comment

clearloop Apr 27, 2021

Choose a reason for hiding this comment

clearloop commented Apr 28, 2021

mattsse left a comment

Choose a reason for hiding this comment

mattsse Apr 28, 2021

Choose a reason for hiding this comment

clearloop Apr 28, 2021 • edited Loading

Choose a reason for hiding this comment

mattsse Apr 28, 2021

Choose a reason for hiding this comment

clearloop Apr 28, 2021 • edited Loading

Choose a reason for hiding this comment

clearloop commented Apr 27, 2021 •

edited

Loading

clearloop Apr 28, 2021 •

edited

Loading

clearloop Apr 28, 2021 •

edited

Loading