Added a backup.skip-not-found option #4
Conversation
|
Good suggestion, however this option may be misleading. What it really does is ignore any clone error. I will pick up your suggestion and think about maybe a better name for it. Another thing that comes to mind is: You'd probably want to know about these right? Would it make sense to dump a list of failed repos to a logfile somewhere or simply logging to console would be enough? |
|
Logging in general could be improved in my opinion. Using something like logrus could be used to easily differentiate between errors and the "Discovered " log calls for example. |
|
Fair enough, I initially set up this tool for personal use and never thought other people would use it. I am familiar with logrus and might make a release to improve logging and make it more configurable. For now, I will be okay with this PR provided you change a few things:
If you don't have the time to do this, let me know and I will pick it up. |
|
I'll pick this up after dinner, so in a few hours. Expect another pull request later as well with a flag to do bare clones rather than actually check out the repositories (something I just noticed while taking a proper look at the go-git documentation. |
|
Great! I will take a look tomorrow then. |
Using this option it will continue with all repositories even when encountering an error. It will only exit with an error after processing all repositories.
When testing this, it turned out I had a couple of repositories starred that got removed (but were still getting returned by Github their API). With this option I can just skip over those repositories, rather than stop and not back up any other pending repositories. I put the default on false to retain original behavior, although in my opinion having this on by default would be more useful.