Skip the git pull on bare repositories #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A second run with -backup.bare-clone would fail as it would still try to retrieve a work tree and do a git pull. Now it will check whether a discovered repository is bare or not. And if it is, it will just skip the git pull and only do a git fetch down the line.
|
Oops 😅 I will do a test tonight and merge/release if it all works nicely. |
|
Nvm, I had 15 minutes before I had to leave. Seems to work alright now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apparently didn't test this properly with #6, but basically it would fail completely upon a second run (or any run there after). With error messages like
2022/04/21 14:13:42 Failed to clone: worktree not available in a bare repository. This pull request will check whether a discovered repository is a bare repository or not. And if it is, it will skip the completegit pullstep (on which it would otherwise fail) and only do a git fetch, which is plenty for a backup.