-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more items in macOS menu bar #5266
feat: add more items in macOS menu bar #5266
Conversation
- "About Chatterino" item which when clicked, opens the SettingsDialog with the "About" tab open. - "Help" menu bar option that has multiple items linking to Wiki, Github, Discord - "Minimise" item which when clicked, minimises the entire Window.
Not sure, but this is what I find when googling for the question if a minimize option is standard for mac: https://developer.apple.com/design/human-interface-guidelines/the-menu-bar#Window-menu As far as I understand it is recommended, but not necessary to do, but I have no experience with Mac at all. |
- Moving `LINK_*` constants into Common.hpp allows for future reuses in other source than just AboutPage.cpp. - After refactoring some of the `LINK_*` constants, include Common.http in AboutPage.cpp to make use of them.
should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Co-authored-by: pajlada <rasmus.karlsson+github@pajlada.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great! Thank you! I'll test this briefly on my macOS Sonoma system then I'm happy to merge this in
Thank you! One thing that's low priority (I think) is about the use of Referencing: https://doc.qt.io/qt-6/qkeysequence.html#details
|
I've tested this and everything works as expected 👍 |
@pajlada oops, I toggled that off when I sent a PR. (Have re-enabled it.) Been a while since I have contributed to some upstream open source stuff, so played around with that option. 😛 Seems @Felanbird (thanks!) has taken care of making it up-to-date with master. 🙏🏽 |
This PR tries to address some of the items listed in the brainstormed list mentioned in #1077