[25.02.27 / TASK-130] Feature - 빠른 조회 기능 구현 및 오류 수정 #17

six-standard · 2025-02-27T10:08:25Z

진행한 일

빠른 조회 기능을 구현하였습니다 (미선택, 최근 7일, 최근 30일, 직접선택)
그래프에서 날짜가 꼬이는 오류를 해결하였습니다. (서버에서 날짜를 이상한 순서로 전송하는 경우였으며, 정렬로 해결)
env가 적용되지 않는 오류를 해결하였습니다. (NextJS에서는 env의 적용 방식으로 인해 변/상수에 할당 시 빈 객체가 할당되게 됨)

process.env의 동작 방식으로 인해 구조분해할당이 안 된다고 합니다..

coderabbitai · 2025-02-27T10:08:36Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

notion-workspace · 2025-02-27T10:09:15Z

날짜별 통계 보기, 간편 날짜 세팅

Nuung · 2025-02-27T15:42:55Z

src/components/auth-required/main/Section/Graph.tsx

+      post = post.sort(
+        (a, b) => new Date(a.date).getTime() - new Date(b.date).getTime(),
+      );


ㅋㅋㅋㅋ이건 지금은 추가하되 추후 뺍시다, 서버 사이드에서 꼭 해줘야하는 건데 ㅠㅠ

동의합니다..
종종 그래프가 튀던 이유가 날짜 정렬 문제여서 급히 핫픽스 느낌으로 넣긴 했는데, 성능상 문제가 생기는 경우도 있을 것으로 보이네요.

Nuung

좋았던 점

이번에는 마이너한 작업들이라 크게 이견없습니다! 점점 고도화 되는 것 같아서 보는게 뿌듯하네요
서버사이드에서 처리해야할 것이 FE 에 전가된 것 같아 슬프네유, 지금은 hot-fix 로 넣되, 나중은 빼시죠! (client-side sorting 연산이,, 데이터가 많아지면 부담이라 ㅠ)
requiredEnv 에서 process.env 로 바꾸는 계기가 궁금하네요!

six-standard · 2025-02-27T16:29:59Z

좋았던 점

이번에는 마이너한 작업들이라 크게 이견없습니다! 점점 고도화 되는 것 같아서 보는게 뿌듯하네요

서버사이드에서 처리해야할 것이 FE 에 전가된 것 같아 슬프네유, 지금은 hot-fix 로 넣되, 나중은 빼시죠! (client-side sorting 연산이,, 데이터가 많아지면 부담이라 ㅠ)

requiredEnv 에서 process.env 로 바꾸는 계기가 궁금하네요!

원래 process.env가 반복되는 게 아쉬워서 requiredEnv로 통합했는데, 실행해보니 env가 빈 객체로 넘어왔습니다.
그래서 좀 찾아보니, NextJS에서 환경 변수를 삽입(Inlining)할 때 env 객체를 그대로 다른 변수에 할당하면 동작하지 않는다고 하더군요..
그래서 어쩔 수 없이 하드코딩 방식으로 변경하였습니다~

자세한 설명은 이 항목의 마지막 부분을 읽어보시면 됩니다!

Jihyun3478

좋았던 점

코드의 전체 가독성이 높아져 보기 편했던 것 같습니다!

ps. 고생하셨습니다! 앞으로도 파이팅입니다🔥

Jihyun3478 · 2025-02-27T23:43:19Z

src/components/auth-required/main/Section/Graph.tsx

-                },
-              },
+              x: { axis: 'x', grid: { color: COLORS.BORDER.SUB } },
+              y: { axis: 'y', grid: { color: COLORS.BORDER.SUB } },


훨씬 가독성이 좋은 것 같아요!👍

Jihyun3478 · 2025-02-27T23:45:28Z

src/components/auth-required/main/Section/Graph.tsx

-    type: 'View',
-  });
+  const [type, setType] = useState({ start: '', end: '', type: 'View' });
+  const [mode, setMode] = useState<ModeType>('none');


cheonHwi

좋았던 점

전체적으로 코드 가독성이 좋아진 것 같습니다.
데이터 정렬은 서버 쪽에서 해주는 방향이 좋을거 같은데,, 빨리 추가해보도록 할게요. 말씀하셨던거처럼 성능 이슈가 있을 수도 있을거 같아요. 빠르게 대응해주셔서 감사합니당 :)

six-standard added 4 commits February 27, 2025 17:19

refactor: DRY 원칙 맞춤

1a4e400

hotfix: process.env 관련 오류 수정

d5124bc

process.env의 동작 방식으로 인해 구조분해할당이 안 된다고 합니다..

modify: 타입 단언

33c80ab

feature: 빠른 조회 기능 구현

0c3db95

six-standard changed the title ~~Feature/quick date pick~~ [25.02.27 / TASK-130] Feature - 빠른 조회 기능 구현 및 오류 수정 Feb 27, 2025

six-standard self-assigned this Feb 27, 2025

six-standard requested review from Nuung, cheonHwi and Jihyun3478 February 27, 2025 10:09

six-standard added bug Something isn't working enhancement New feature or request labels Feb 27, 2025

Nuung reviewed Feb 27, 2025

View reviewed changes

Nuung approved these changes Feb 27, 2025

View reviewed changes

Jihyun3478 approved these changes Feb 27, 2025

View reviewed changes

cheonHwi approved these changes Feb 28, 2025

View reviewed changes

six-standard merged commit 60920e6 into dev Feb 28, 2025
1 check passed

six-standard deleted the feature/quick-date-pick branch March 6, 2025 04:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[25.02.27 / TASK-130] Feature - 빠른 조회 기능 구현 및 오류 수정 #17

[25.02.27 / TASK-130] Feature - 빠른 조회 기능 구현 및 오류 수정 #17

Uh oh!

six-standard commented Feb 27, 2025

Uh oh!

coderabbitai bot commented Feb 27, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

notion-workspace bot commented Feb 27, 2025

Uh oh!

Nuung Feb 27, 2025

Uh oh!

six-standard Feb 27, 2025

Uh oh!

Nuung left a comment •

edited by six-standard

Loading

Uh oh!

six-standard commented Feb 27, 2025

좋았던 점

Uh oh!

Jihyun3478 left a comment

Uh oh!

Jihyun3478 Feb 27, 2025

Uh oh!

Jihyun3478 Feb 27, 2025

Uh oh!

cheonHwi left a comment

Uh oh!

Uh oh!

Uh oh!

[25.02.27 / TASK-130] Feature - 빠른 조회 기능 구현 및 오류 수정 #17

[25.02.27 / TASK-130] Feature - 빠른 조회 기능 구현 및 오류 수정 #17

Uh oh!

Conversation

six-standard commented Feb 27, 2025

진행한 일

Uh oh!

coderabbitai bot commented Feb 27, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

notion-workspace bot commented Feb 27, 2025

Uh oh!

Nuung Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

six-standard Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

Nuung left a comment • edited by six-standard Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

좋았던 점

Uh oh!

six-standard commented Feb 27, 2025

좋았던 점

Uh oh!

Jihyun3478 left a comment

Choose a reason for hiding this comment

좋았던 점

Uh oh!

Jihyun3478 Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

Jihyun3478 Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

cheonHwi left a comment

Choose a reason for hiding this comment

좋았던 점

Uh oh!

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)

Nuung left a comment •

edited by six-standard

Loading