Merge pull request #168 from Ches-ctrl/2024-05-19-user-feedback

2024 05 19 user feedback

.github/workflows/rubyonrails.yml

@@ -61,3 +61,22 @@ jobs:
 
       - name: Lint Ruby files
         run: bundle exec rubocop --parallel
+
+  brakeman:
+      runs-on: ubuntu-latest
+      steps:
+        - name: Checkout code
+          uses: actions/checkout@v3
+        - name: Install Ruby and gems
+          uses: ruby/setup-ruby@55283cc23133118229fd3f97f9336ee23a179fcf # v1.146.0
+          with:
+            bundler-cache: true
+        - name: Install dependencies
+          run: bundle install
+        - name: Run Brakeman
+          run: bundle exec brakeman -f sarif -o output.sarif.json
+          continue-on-error: true
+        - name: Upload SARIF
+          uses: github/codeql-action/upload-sarif@v2
+          with:
+            sarif_file: output.sarif.json

.slugignore

@@ -34,6 +34,9 @@ spec/**
 .gitignore
 .dockerignore
 
+# Ignore contributing files
+CONTRIBUTING.md
+
 # Ignore yml files generated by VCR.
 spec/fixtures/cassettes/ApplicantTrackingSystem/*.yml
 

Gemfile

@@ -52,7 +52,7 @@ gem "autoprefixer-rails"
 gem "sassc-rails"
 gem "font-awesome-sass", "~> 6.5.1"
 gem "simple_form"
-gem 'psych', "~> 4.0" # Extra gem as per Le Wagon setup for Linux laptops
+gem 'psych', "~> 5.1.2" # Extra gem as per Le Wagon setup for Linux laptops
 
 # Middleware
 gem 'rack-cors'
@@ -80,8 +80,9 @@ gem "ruby-openai"
 gem 'meta-tags'
 # gem 'sitemap_generator' # TODO: install this gem for sitemap generation
 
-# Email
-# gem 'sendgrid-ruby' # TODO: install this gem for sending emails
+# Email & CRM
+gem 'hubspot-api-client'
+gem 'sendgrid-ruby'
 
 # Importing, Parsing & APIs
 gem 'csv' # can probably use ruby standard library
@@ -91,7 +92,7 @@ gem 'rails-html-sanitizer'
 gem "flipper-active_record", "~> 1.3"
 
 # Monitoring
-# gem 'newrelic_rpm' # TODO: install this gem for monitoring
+gem 'newrelic_rpm'
 
 # Analytics
 # gem 'analytics-ruby', '~> 2.4.0', :require => 'segment/analytics' # TODO: install this gem for analytics
@@ -106,8 +107,7 @@ gem "flipper-active_record", "~> 1.3"
 # gem 'sentry-raven' # TODO: install this gem for error tracking
 
 # Front-end
-gem 'will_paginate', '~> 4.0' # TODO: Update to kaminari now index page is fixed (better maintained / looks nicer)
-# gem 'kaminari'
+gem 'kaminari'
 gem "high_voltage", "~> 3.1"
 gem 'tinymce-rails' # TODO: now have trix and action text (check whether we need to replace)
 
@@ -126,6 +126,10 @@ group :development, :test do
   gem 'rubocop-performance'
   gem 'rubocop-rails'
   gem 'rubocop-rspec'
+  # gem 'parallel_tests' # TODO: install this gem for parallel testing
+
+  # Security
+  gem 'brakeman', require: false
 
   # Email
   # gem 'letter_opener' # TODO: install this gem for email testing
@@ -138,9 +142,6 @@ group :development do
   gem "better_errors"
   gem "binding_of_caller"
 
-  # Security
-  # gem 'brakeman', require: false # TODO: install this gem for security checks
-
   # Performance
   # Add speed badges [https://github.com/MiniProfiler/rack-mini-profiler]
   # gem "rack-mini-profiler" # TODO: install this gem for performance monitoring